这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix jackson deprecations #3890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2023
Merged

Fix jackson deprecations #3890

merged 1 commit into from
Feb 8, 2023

Conversation

@Sineaggi
Copy link
Contributor

@Sineaggi Sineaggi commented Dec 12, 2022 •
edited
Loading

Fix a few jackson deprecations. ObjectMapper.configure has been deprecated

> Task :jib:jib-core:compileJava
/Users/cwalker/git/jib/jib-core/src/main/java/com/google/cloud/tools/jib/registry/credentials/DockerConfigCredentialRetriever.java:91: warning: [deprecation] configure(MapperFeature,boolean) in ObjectMapper has been deprecated
        new ObjectMapper().configure(MapperFeature.ACCEPT_CASE_INSENSITIVE_PROPERTIES, true);
                          ^
/Users/cwalker/git/jib/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/LocalBaseImageSteps.java:221: warning: [deprecation] configure(MapperFeature,boolean) in ObjectMapper has been deprecated
              .configure(MapperFeature.ACCEPT_CASE_INSENSITIVE_PROPERTIES, true)
              ^
2 warnings

The replacement being

Since 2.13 use {@code JsonMapper.builder().configure(...)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Sineaggi Sineaggi force-pushed the fix-jackson-deprecations branch from 57b2235 to 25fc337 Compare January 20, 2023 16:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Sineaggi
Copy link
Contributor Author

Sineaggi commented Feb 4, 2023

Bump

emmileaf
emmileaf approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@emmileaf emmileaf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Apologies for the delay in reviewing this, and thank you for the contribution!

We are currently working to resolve some issues in the CI, and will merge this PR after fixing #3925.

@emmileaf emmileaf merged commit 5b6b145 into GoogleContainerTools:master Feb 8, 2023
@Sineaggi Sineaggi deleted the fix-jackson-deprecations branch February 8, 2023 21:11
@Sineaggi Sineaggi mentioned this pull request Feb 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@emmileaf emmileaf emmileaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sineaggi @emmileaf @kokoro-team