-
Notifications
You must be signed in to change notification settings - Fork 18
fix creds scope for SAs during refresh #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix creds scope for SAs during refresh #209
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @M4C4R, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a potential issue where the default credentials used for refreshing image registry pull secrets might lack the appropriate scope for Service Accounts. By explicitly defining the cloud-platform
scope during credential discovery, it ensures the refresh process operates with the correct permissions, improving reliability and security.
Highlights
- Credential Scope Fix: The
google.FindDefaultCredentials
call within therefreshAllPullSecrets
function inserver.go
has been updated to explicitly request thehttps://www.googleapis.com/auth/cloud-platform
scope. This ensures that Service Accounts (SAs) have the necessary permissions when refreshing image registry pull secrets.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue with credential scopes for service accounts during the periodic refresh of pull secrets. The change adds the necessary cloud-platform
scope when finding default credentials, which aligns it with the logic used for newly created namespaces. My review includes one suggestion to define the scope URL as a constant to improve maintainability by avoiding code duplication.
@@ -170,7 +170,7 @@ func deletePullSecret(clientset *kubernetes.Clientset, ns corev1.Namespace) erro | |||
|
|||
// refreshAllPullSecrets deletes and recreates image registry pull secrets for all namespaces | |||
func refreshAllPullSecrets() error { | |||
creds, err := google.FindDefaultCredentials(context.Background()) | |||
creds, err := google.FindDefaultCredentials(context.Background(), "https://www.googleapis.com/auth/cloud-platform") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this change correctly adds the necessary scope, the scope URL "https://www.googleapis.com/auth/cloud-platform"
is now duplicated (it also appears on line 82 in watchNamespaces
).
To improve maintainability and avoid magic strings, please define this URL as a package-level constant and use it in both places.
For example, you could add the following at the top level of the file:
const gcpAuthScope = "https://www.googleapis.com/auth/cloud-platform"
And then use gcpAuthScope
here.
This PR: #169 missed the case when the secrets are refreshed after an hour.