这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@googlyrahman
Copy link
Member

Automated: Migrate paths from gsutil to gcloud storage

This CL is part of the on going effort to migrate from the legacy gsutil tool to the new and improved gcloud storage command-line interface. gcloud storage is the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with other gcloud components. 🚀

Automation Details

This change was generated automatically by an agent that targets users of gsutil.
The transformations applied are based on the gsutil to gcloud storage migration guide.

⚠️ Action Required: Please Review and Test Carefully

While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between gsutil and gcloud storage that could impact your workflows.
For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the gcloud storage rsync command has a different file deletion logic than gsutil rsync, which could lead to unintended file deletions.

Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.

Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.

Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.

Support and Collaboration

The GCS CLI team is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.
We are happy to work with you to test and adjust these changes as needed.

Contact: gcs-cli-hyd@google.com

We appreciate your partnership in this important migration effort!

cc: @sushantkhanna

@googlyrahman googlyrahman requested a review from a team as a code owner October 17, 2025 20:04
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @googlyrahman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the migration of legacy gsutil commands to the modern gcloud storage command-line interface within several Jupyter notebooks. This transition is part of an ongoing effort to leverage gcloud storage for its improved performance, unified authentication, and a more consistent command structure across Google Cloud services. The changes were automatically generated based on the official migration guide.

Highlights

  • Command Migration: Replaced various gsutil commands with their gcloud storage equivalents across multiple Jupyter notebooks. This includes commands for creating buckets (mb to buckets create), listing objects (ls -al to ls --all-versions --long), copying files (cp to cp), and removing resources (rm -r to rm --recursive).
  • IAM Policy Updates: Updated gsutil iam ch commands to use gcloud storage buckets add-iam-policy-binding for managing bucket permissions. A note has been added in one instance to highlight the increased complexity for migrating iam ch scripts.
  • Notebook Consistency: The changes ensure consistency in Google Cloud Storage interactions across several Jupyter notebooks, aligning them with the recommended and modern gcloud storage command-line interface.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@googlyrahman
Copy link
Member Author

Hi @holtskinner, Can we get your review on this PR? Thanks!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automates the migration of gsutil commands to their gcloud storage equivalents across several Jupyter notebooks. The changes are mostly correct, but I've identified a few issues. There are inconsistencies in the use of the --location flag, a critical JSON formatting error in one of the notebooks that will prevent it from loading, and a potential bug in another notebook where a grep command will fail due to a case-sensitivity issue after the migration. I've provided suggestions to fix these issues.

Comment on lines +1723 to +1724
! gcloud storage ls $folder/prediction*\n", "\n",
! gcloud storage cat $folder/prediction*\n", " break\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The automated migration has corrupted this cell's source code. The leading " and indentation have been removed from these lines, which breaks the JSON structure of the notebook and will cause it to fail to load. Please restore the correct formatting.

        "        ! gcloud storage ls $folder/prediction*\n",
        "\n",
        "        ! gcloud storage cat $folder/prediction*\n",
        "        break\n",

" shell_output = ! gsutil ls -Lb {BUCKET_NAME} | grep \"Location constraint:\" | sed \"s/Location constraint://\"\n",
" bucket_region = shell_output[0].strip().lower()\n",
"# Note: The format of the full listing output is different. gcloud storage uses a title case for keys and will not display a field if its value is \"None\".\n",
" shell_output = ! gcloud storage ls --full --buckets {BUCKET_NAME} | grep \"Location constraint:\" | sed \"s/Location constraint://\"\n", " bucket_region = shell_output[0].strip().lower()\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The grep command is case-sensitive and will fail to find the location constraint. The output of gcloud storage ls --full uses "Location Constraint:" (title case), whereas the old gsutil ls -Lb command used "Location constraint:" (sentence case). Please update the grep pattern to match the new output format.

    shell_output = ! gcloud storage ls --full --buckets {BUCKET_NAME} | grep "Location Constraint:" | sed "s/Location Constraint://"

"source": [
"! gsutil mb -l $REGION $BUCKET_NAME"
]
"! gcloud storage buckets create --location $REGION $BUCKET_NAME" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other files in this PR and for better script clarity, it's recommended to use --location=$REGION instead of --location $REGION. While gcloud might handle both, using the equals sign is more explicit and less prone to parsing errors in shell scripts.

        "! gcloud storage buckets create --location=$REGION $BUCKET_NAME"

"source": [
"! gsutil mb -l $REGION gs://$BUCKET_NAME"
]
"! gcloud storage buckets create --location $REGION gs://$BUCKET_NAME" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other files in this PR and for better script clarity, it's recommended to use --location=$REGION instead of --location $REGION. While gcloud might handle both, using the equals sign is more explicit and less prone to parsing errors in shell scripts.

        "! gcloud storage buckets create --location=$REGION gs://$BUCKET_NAME"

"source": [
"! gsutil mb -l $REGION $BUCKET_URI"
]
"! gcloud storage buckets create --location $REGION $BUCKET_URI" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other files in this PR and for better script clarity, it's recommended to use --location=$REGION instead of --location $REGION. While gcloud might handle both, using the equals sign is more explicit and less prone to parsing errors in shell scripts.

        "! gcloud storage buckets create --location=$REGION $BUCKET_URI"

"source": [
"! gsutil mb -l {LOCATION} -p {PROJECT_ID} {BUCKET_URI}"
]
"! gcloud storage buckets create --location {LOCATION} --project {PROJECT_ID} {BUCKET_URI}" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other files in this PR and for better script clarity, it's recommended to use --location={LOCATION} instead of --location {LOCATION}. While gcloud might handle both, using the equals sign is more explicit and less prone to parsing errors in shell scripts.

        "! gcloud storage buckets create --location={LOCATION} --project {PROJECT_ID} {BUCKET_URI}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant