fix(spanner): check for empty before delete #4047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diegomarquezp
approved these changes
Aug 5, 2025
zhumin8
added a commit
that referenced
this pull request
Aug 19, 2025
spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with error from Spanner: `INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.` **Trigger of this behavior change:** spanner activated multiplexed sessions by default in [googleapis/java-spanner#3996](googleapis/java-spanner#3996), which triggers this error. When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see [pr](googleapis/java-spanner#4023)), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token. Fixes #4046
zhumin8
added a commit
that referenced
this pull request
Aug 19, 2025
spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with error from Spanner: `INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.` **Trigger of this behavior change:** spanner activated multiplexed sessions by default in [googleapis/java-spanner#3996](googleapis/java-spanner#3996), which triggers this error. When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see [pr](googleapis/java-spanner#4023)), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token. Fixes #4046
zhumin8
added a commit
that referenced
this pull request
Aug 19, 2025
spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with error from Spanner: `INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.` **Trigger of this behavior change:** spanner activated multiplexed sessions by default in [googleapis/java-spanner#3996](googleapis/java-spanner#3996), which triggers this error. When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see [pr](googleapis/java-spanner#4023)), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token. Fixes #4046
zhumin8
added a commit
that referenced
this pull request
Aug 19, 2025
backport fix from #4047 spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with error from Spanner: `INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.` **Trigger of this behavior change:** spanner activated multiplexed sessions by default in [googleapis/java-spanner#3996](googleapis/java-spanner#3996), which triggers this error. When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see [pr](googleapis/java-spanner#4023)), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token. Fixes #4046
zhumin8
added a commit
that referenced
this pull request
Aug 19, 2025
Backport fix. spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with error from Spanner: `INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.` **Trigger of this behavior change:** spanner activated multiplexed sessions by default in [googleapis/java-spanner#3996](googleapis/java-spanner#3996), which triggers this error. When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see [pr](googleapis/java-spanner#4023)), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token.
zhumin8
added a commit
that referenced
this pull request
Aug 19, 2025
Backport fix. spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with error from Spanner: `INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.` **Trigger of this behavior change:** spanner activated multiplexed sessions by default in [googleapis/java-spanner#3996](googleapis/java-spanner#3996), which triggers this error. When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see [pr](googleapis/java-spanner#4023)), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token. Fixes #4046
zhumin8
pushed a commit
that referenced
this pull request
Aug 19, 2025
🤖 I have created a release *beep* *boop* --- ## [3.9.8](v3.9.7...v3.9.8) (2025-08-19) ### Bug Fixes * **spanner:** check for empty before delete ([#4047](#4047)) ([#4079](#4079)) ([e0a2716](e0a2716)), closes [#4046](#4046) ### Dependencies * bump com.google.cloud:libraries-bom from 26.65.0 to 26.66.0 ([#4066](#4066)) ([e15f17a](e15f17a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
zhumin8
pushed a commit
that referenced
this pull request
Aug 20, 2025
🤖 I have created a release *beep* *boop* --- ## [6.3.2](v6.3.1...v6.3.2) (2025-08-19) ### Bug Fixes * **spanner:** check for empty before delete ([#4047](#4047)) ([#4077](#4077)) ([cb1f687](cb1f687)), closes [#4046](#4046) ### Dependencies * bump com.google.cloud:libraries-bom from 26.65.0 to 26.66.0 ([#4067](#4067)) ([970c11c](970c11c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
zhumin8
pushed a commit
that referenced
this pull request
Aug 20, 2025
🤖 I have created a release *beep* *boop* --- ## [7.2.0](v7.1.0...v7.2.0) (2025-08-19) ### Features * Update root reference docs with latest version ([#4081](#4081)) ([20c45f9](20c45f9)) ### Bug Fixes * **deps:** update dependency com.google.api:gapic-generator-java-bom to v2.61.0 ([#4071](#4071)) ([f96a628](f96a628)) * **deps:** update dependency com.google.cloud:libraries-bom to v26.66.0 ([#4070](#4070)) ([4aa58cd](4aa58cd)) * **doc:** fix secret manager section header levels ([#4060](#4060)) ([82df717](82df717)), closes [#4072](#4072) * **docs:** add missing parameter.adoc to documentation index ([#4069](#4069)) ([23dc9ae](23dc9ae)) * remove unnecessary backslashes ([#4083](#4083)) ([0cfe9d9](0cfe9d9)) * **spanner:** check for empty before delete ([#4047](#4047)) ([b50c092](b50c092)) ### Documentation * Add 80% test coverage requirement for new code ([#4062](#4062)) ([092a1dd](092a1dd)) * update reference documentation links to the latest ([#4049](#4049)) ([4e66678](4e66678)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
zhumin8
pushed a commit
that referenced
this pull request
Aug 27, 2025
🤖 I have created a release *beep* *boop* --- ## [5.13.2](v5.13.1...v5.13.2) (2025-08-20) ### Bug Fixes * **spanner:** check for empty before delete ([#4047](#4047)) ([#4078](#4078)) ([319cf41](319cf41)) ### Dependencies * bump com.google.cloud:libraries-bom from 26.65.0 to 26.66.0 ([#4080](#4080)) ([edd3237](edd3237)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spanner IT fails for
deleteAllById_doesNothingOnEmptyIdstest with error from Spanner:INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.Trigger of this behavior change:
spanner activated multiplexed sessions by default in googleapis/java-spanner#3996, which triggers this error.
When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see pr), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token.
BEGIN_COMMIT_OVERRIDE
fix(spanner): check for empty before delete (#4047)
END_COMMIT_OVERRIDE
Fixes #4046