这是indexloc提供的服务，不要输入任何密码
Skip to content

UAP should not restart the plugin if a conflicting installation is detected or the given ops agent config is invalid #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 15, 2025
Merged

UAP should not restart the plugin if a conflicting installation is detected or the given ops agent config is invalid #2090

merged 8 commits into from
Oct 15, 2025

Conversation

@XuechunHou
Copy link
Contributor

@XuechunHou XuechunHou commented Oct 13, 2025 •
edited
Loading

Description

Conflicting installation detection and Ops Agent configuration validation checks are performed within the Start() method. Failures in these checks should not trigger a UAP plugin restart or rollback because they require user intervention and cannot be resolved by restarts.

If the plugin returns an RPC error during the Start() call, UAP will attempt to restart the plugin revision up to three times. A rollback is initiated if all attempts fail.

Related issue

b/452138776

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@XuechunHou XuechunHou added the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 14, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 14, 2025
@XuechunHou XuechunHou requested a review from jinghan-ma October 15, 2025 01:09
@XuechunHou XuechunHou changed the title Certain Errors are not returned to UAP. UAP should not restart the plugin if a conflicting installation is detected or if the given ops agent config is invalid Oct 15, 2025
@XuechunHou XuechunHou changed the title UAP should not restart the plugin if a conflicting installation is detected or if the given ops agent config is invalid UAP should not restart the plugin if a conflicting installation is detected or the given ops agent config is invalid Oct 15, 2025
jinghan-ma
jinghan-ma approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@jinghan-ma jinghan-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might want to sync with UAP post Public Preview on how to report errors on startup that doesn't trigger auto restart and rollback

@XuechunHou XuechunHou merged commit 0eda99b into master Oct 15, 2025
43 of 59 checks passed
@XuechunHou XuechunHou deleted the uap-error-handling branch October 15, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinghan-ma jinghan-ma jinghan-ma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@XuechunHou @jinghan-ma @stackdriver-instrumentation-release