这是indexloc提供的服务，不要输入任何密码
Skip to content

[Testing] Switch integration tests to use gce_testing.go from its new location. #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 29, 2025
Merged

[Testing] Switch integration tests to use gce_testing.go from its new location. #1936

merged 6 commits into from
Apr 29, 2025

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Apr 28, 2025 •
edited
Loading

Description

GoogleCloudPlatform/opentelemetry-operations-collector#285 moved gce_testing.go over there. This PR switches this code over to that new location. This is Step 4 from Proposal 1 of go/sdi-move-gce-testing.

go.mod and go.sum were updated using these two commands:

go get github.com/GoogleCloudPlatform/opentelemetry-operations-collector/integration_test/gce-testing-internal/gce@master
go mod tidy

Related issue

b/410866041

How has this been tested?

presubmits

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans
Switch integration tests to use gce_testing.go from its new location.
e20dd91 
GoogleCloudPlatform/opentelemetry-operations-collector#285
is moving gce_testing.go over there. This PR switches this code over to
that new location.
@martijnvans martijnvans mentioned this pull request Apr 28, 2025
Merged
9 tasks
@martijnvans martijnvans changed the title Switch integration tests to use gce_testing.go from its new location. [Testing] Switch integration tests to use gce_testing.go from its new location. Apr 28, 2025
@martijnvans martijnvans mentioned this pull request Apr 29, 2025
Merged
9 tasks
@martijnvans martijnvans requested a review from avilevy18 April 29, 2025 18:01
@martijnvans martijnvans merged commit a0cab05 into master Apr 29, 2025
15 of 21 checks passed
@martijnvans martijnvans deleted the martijnvans-gce-testing-switch branch April 29, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avilevy18 avilevy18 avilevy18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martijnvans @avilevy18