[confgenerator] Add parse_regex in otel logging.
#1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c47c9a5 to
648251d
Compare
c674e32 to
7b90c3a
Compare
7b90c3a to
ba974ed
Compare
3a98ac7 to
e3d98df
Compare
785484a to
ba509d5
Compare
parse_regex in otel logging.parse_regex in otel logging.
ba509d5 to
a97c696
Compare
955bf0f to
d5f80a8
Compare
confgenerator/testdata/goldens/invalid-logging-otel-unsupported_processor/input.yaml
Outdated
Show resolved
Hide resolved
f703fd3 to
58503fd
Compare
quentinmit
approved these changes
Aug 6, 2025
confgenerator/logging_processors.go
Outdated
Member
There was a problem hiding this comment.
Feel free to address this in a followup PR:
I would like us to be a little smarter about whether we use onigiruma for the regex. For this code, we can just check if the regex compiles:
output := ottl.ExtractPatternsRubyRegex(fromAccessor, p.Regex)
if _, err := regexp.Compile(p.Regex); err == nil {
// If it compiles as a Go regex, use the built-in parser
output = ottl.ExtractPatterns(fromAccessor, p.Regex)
}
// ...
cachedParsedRegex.SetIf(output, fromAccessor.IsPresent()),
I also want to expose this (whether or not a regex is Go-compatible) as a feature flag so we can track this across customer deployments.
Contributor
Author
There was a problem hiding this comment.
I will do this in a followup PR. Created tracker for this in : b/436898109.
58503fd to
06bc949
Compare
…s in otel logging.
…he" processor since `apache_access` is supported now.
e74de76 to
19f87d3
Compare
Contributor
Author
|
All integration test failures are unrelated, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
parse_regexsupport on Otel Logging. This is based on theOTTLfunctionExtractPatternsRubyRegexadded in GoogleCloudPlatform/opentelemetry-operations-collector#350.Details to consider
googlecloudexporterwhen ishttpRequest.statusset aninteger.output_otel.yamlwith missinghttpRequestmap.httpRequest.statusinteger value. opentelemetry-operations-go#1062.There is an issue inUbuntu Jammynot finding theIANA Time Zone databaseso settingTZ=America/Los_Angeleswas not working in transformation tests :The Otel docs suggests addingtime/tzadatain the Collector Build. This is the best solution.I've installedtzdatadirectly which works, but may not be the best solution overall.More details in Updating opentelemetry-operantions-collector to bring googleclientauth #2012 (comment).Related issue
b/434196968
How has this been tested?
Checklist: