这是indexloc提供的服务，不要输入任何密码
Skip to content

Add support for RL8/9 optimized versions #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 3, 2024
Merged

Add support for RL8/9 optimized versions #1788

merged 4 commits into from
Sep 3, 2024

Conversation

@jefferbrecht
Copy link
Member

@jefferbrecht jefferbrecht commented Aug 30, 2024 •
edited
Loading

Description

This PR adds test coverage for the GCP-optimized versions of RL8/9:

  • rocky-linux-8-optimized-gcp
  • rocky-linux-9-optimized-gcp
  • rocky-linux-9-optimized-gcp-arm64

This excludes rocky-linux-8-optimized-gcp-arm64 (for now) because we still need to set up the build pipeline for it, which will come separately.

Related issue

b/294548275

How has this been tested?

Letting presubmits run.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
    • This PR introduces user visible changes and the corresponding documentation change has been staged.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@jefferbrecht
Copy link
Member Author

jefferbrecht commented Aug 30, 2024

Presubmits passed:

The other test failures look unrelated so I'll unwind the temporary changes now and then this should be ready for review.

@jefferbrecht jefferbrecht force-pushed the jefferbrecht-rhel-optimized branch from 9a36279 to d769d07 Compare August 30, 2024 20:35
@jefferbrecht
Copy link
Member Author

jefferbrecht commented Aug 30, 2024

Whoops, forgot rocky-linux-cloud:rocky-linux-9-optimized-gcp-arm64 -- rebased and will let the tests rerun.

@jefferbrecht
Copy link
Member Author

jefferbrecht commented Aug 30, 2024

Now we've got a full set of passing presubmits:

@jefferbrecht jefferbrecht changed the title Jefferbrecht rhel optimized Add support for RL8/9 optimized versions Aug 30, 2024
@jefferbrecht jefferbrecht marked this pull request as ready for review September 3, 2024 17:23
@jefferbrecht
Copy link
Member Author

jefferbrecht commented Sep 3, 2024

Test failures look unrelated, merging.

@jefferbrecht jefferbrecht merged commit 1246ead into master Sep 3, 2024
@jefferbrecht jefferbrecht deleted the jefferbrecht-rhel-optimized branch September 3, 2024 20:26
@jefferbrecht jefferbrecht restored the jefferbrecht-rhel-optimized branch September 3, 2024 20:26
@jefferbrecht jefferbrecht deleted the jefferbrecht-rhel-optimized branch September 3, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avilevy18 avilevy18 avilevy18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jefferbrecht @avilevy18