Inline Apache web server configuration into the application install scripts. #1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9061322 to
f756dab
Compare
4f3266c to
2d268f7
Compare
martijnvans
requested changes
Jul 29, 2024
integration_test/third_party_apps_test/applications/apache/debian_ubuntu/install
Outdated
Show resolved
Hide resolved
integration_test/third_party_apps_test/applications/apache/sles/install
Outdated
Show resolved
Hide resolved
integration_test/third_party_apps_test/applications/apache/centos_rhel/install
Show resolved
Hide resolved
This reverts commit 2d268f7.
martijnvans
reviewed
Aug 3, 2024
Contributor
martijnvans
left a comment
There was a problem hiding this comment.
I left a comment up above asking why the configuration directory changed in this PR.
martijnvans
approved these changes
Aug 5, 2024
This gives a clear indication in tests that mod_status has been set up properly, making it easier to debug any issues.
b69ff61 to
9fb0f55
Compare
Contributor
Author
|
Apache third-party tests succeeded on all platforms. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the inline configuration when installing Apache web server in tests.
How has this been tested?
Integration tests.
Checklist: