这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@braydonk
Copy link
Contributor

@braydonk braydonk commented Jul 11, 2024

Description

CentOS 7 is now EOL, and all references and configuration for it are being removed.

Related issue

b/350698170

How has this been tested?

Integration tests in this PR.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@braydonk braydonk requested a review from igorpeshansky July 11, 2024 19:20
@braydonk braydonk force-pushed the braydonk-remove-buster branch from 44474ea to 95ef167 Compare July 12, 2024 02:58
@braydonk braydonk force-pushed the braydonk-remove-centos7 branch from 1f0f58b to ad8ca47 Compare July 12, 2024 02:58
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: as-is, this PR will break our build infrastructure. Let's deal with centos8->rockylinux8 in a separate PR.

@braydonk braydonk force-pushed the braydonk-remove-centos7 branch from 4e3f6cd to afc5fbd Compare July 12, 2024 15:47
@braydonk braydonk changed the title Cleanup CentOS 7 and 8 Cleanup CentOS 7 Jul 12, 2024
@braydonk
Copy link
Contributor Author

I've put all the CentOS 8 changes back where they were.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debian-10->debian-11 rename should probably have been part of #1752, but I'll just cross-link them here.

@igorpeshansky igorpeshansky self-requested a review July 12, 2024 21:55
@braydonk braydonk force-pushed the braydonk-remove-centos7 branch from 6a5ebbe to c073e73 Compare July 15, 2024 13:43
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Base automatically changed from braydonk-remove-buster to master July 23, 2024 15:12
remove additional debian-10 references

in progress

use correct GCS URL and Debian version

Cleanup CentOS

CentOS 7 is now EOL, and all references and configuration for it are
being removed. I stumbled on some remaining reference to CentOS8, for
which support has already been removed and there were some dangling
references in our code.

reinstate centos8

restore deleted centos8 config

address review comments
@braydonk braydonk force-pushed the braydonk-remove-centos7 branch from c073e73 to 2c9e901 Compare July 23, 2024 15:28
@igorpeshansky igorpeshansky mentioned this pull request Jul 23, 2024
9 tasks
@braydonk braydonk merged commit 2a0553a into master Jul 24, 2024
@braydonk braydonk deleted the braydonk-remove-centos7 branch July 24, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants