这是indexloc提供的服务，不要输入任何密码
Skip to content

Disable PacApiConnErr check #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2024
Merged

Disable PacApiConnErr check #1586

merged 1 commit into from
Jan 22, 2024

Conversation

@jefferbrecht
Copy link
Member

@jefferbrecht jefferbrecht commented Jan 22, 2024 •
edited by igorpeshansky
Loading

Description

The endpoint seems to return 404 if you request it too early during VM startup. Disable it for now until we figure out the root cause to unblock the integration tests.

Related issue

b/321220138

How has this been tested?

Will let presubmits run.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
    • This PR introduces user visible changes and we're leaving the documentation as-is for now because 1) users will still be running older versions of the agent that produce PacApiConnErr, and 2) we intend for this to be a brief, temporary change
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

franciscovalentecastro
franciscovalentecastro approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefferbrecht
Disable PacApiConnErr check
cab1927 
The endpoint seems to return 404 if you request it too early
during VM startup. Disable it for now until we figure out the root cause to unblock the integration tests.
@jefferbrecht jefferbrecht force-pushed the jefferbrecht-network-checks branch from 52ec1cf to cab1927 Compare January 22, 2024 15:46
@jefferbrecht
Copy link
Member Author

jefferbrecht commented Jan 22, 2024

The failing test looks like an unrelated flake; merging.

@jefferbrecht jefferbrecht merged commit 7225150 into master Jan 22, 2024
@jefferbrecht jefferbrecht deleted the jefferbrecht-network-checks branch January 22, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jefferbrecht @franciscovalentecastro