这是indexloc提供的服务，不要输入任何密码
Skip to content

confgenerator: sanitize metadata values in the gce_resource detector #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2024
Merged

confgenerator: sanitize metadata values in the gce_resource detector #1553

merged 1 commit into from
Jan 4, 2024

Conversation

@ridwanmsharif
Copy link
Contributor

@ridwanmsharif ridwanmsharif commented Jan 2, 2024

Description

This change sanitizes the metadata values so strings of the form ${...:...} are not expanded in the OTel configs.

Related issue

b/311724243
Resolves #1517.

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/sanitize branch 2 times, most recently from 14b07fc to 7804d26 Compare January 2, 2024 20:12
LujieDuan
LujieDuan reviewed Jan 3, 2024
View reviewed changes
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/sanitize branch from 7804d26 to 3a423a8 Compare January 3, 2024 17:41
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/sanitize branch from 3a423a8 to 70ad38e Compare January 3, 2024 17:42
LujieDuan
LujieDuan approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@LujieDuan LujieDuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/sanitize branch from 70ad38e to 9555178 Compare January 3, 2024 20:53
@ridwanmsharif
confgenerator: sanitize metadata values in the gce_resource detector
3c75cbe 
This change sanitizes the metadata values so strings of the form
`${...:...}` are not expanded in the OTel configs.

Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/sanitize branch from 9555178 to 3c75cbe Compare January 4, 2024 06:35
@ridwanmsharif ridwanmsharif merged commit 68111d6 into master Jan 4, 2024
@ridwanmsharif ridwanmsharif deleted the ridwanmsharif/sanitize branch July 22, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LujieDuan LujieDuan LujieDuan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prometheus Config Generation Can Build Invalid Config Due To Inability To Skip Specific GCE Metadata Tags

3 participants

@ridwanmsharif @LujieDuan