这是indexloc提供的服务，不要输入任何密码
Skip to content

Terraform changes for SCIM Token API #15727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Terraform changes for SCIM Token API #15727

wants to merge 7 commits into from
+367 −4

Conversation

@jaideoka
Copy link

@jaideoka jaideoka commented Nov 14, 2025 •
edited
Loading

Add SCIM Token resource under workforce pool provider SCIM Tenant. This pr also adds a mandatory claim_mapping field to SCIM tenant. This is because the field has been made mandatory in the backend and the field being absent in a call to the backend will throw an error. It should be okay to make the change because the Terraform for both Tenant and Token was still under development and we don't have customers using it as of today.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_iam_workforce_pool_provider_scim_token`

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 965 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 965 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Tests analytics

Total tests: 32
Passed tests: 30
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update

Get to know how VCR tests work

@jaideoka jaideoka marked this pull request as ready for review November 14, 2025 18:36
@github-actions github-actions bot requested a review from melinath November 14, 2025 18:37
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@jaideoka
Add new fields in SCIM Tenant to resolve error caused due to changes …
fefc40a 
…in backend which makes these fields mandatory
@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 1083 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 11 files changed, 1083 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 142 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field claim_mapping added as required on pre-existing resource google_iam_workforce_pool_provider_scim_tenant - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Tests analytics

Total tests: 32
Passed tests: 28
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimTenant_iamWorkforcePoolProviderScimTenantBasicExample
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimTenant_update
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProviderScimTenant_iamWorkforcePoolProviderScimTenantBasicExample [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProviderScimTenant_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 1112 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 11 files changed, 1112 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 142 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field claim_mapping added as required on pre-existing resource google_iam_workforce_pool_provider_scim_tenant - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Tests analytics

Total tests: 32
Passed tests: 30
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 1112 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 11 files changed, 1112 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 142 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field claim_mapping added as required on pre-existing resource google_iam_workforce_pool_provider_scim_tenant - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Tests analytics

Total tests: 32
Passed tests: 30
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 1112 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 11 files changed, 1112 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 142 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field claim_mapping added as required on pre-existing resource google_iam_workforce_pool_provider_scim_tenant - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Tests analytics

Total tests: 32
Passed tests: 30
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 1112 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 11 files changed, 1112 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 142 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field claim_mapping added as required on pre-existing resource google_iam_workforce_pool_provider_scim_tenant - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

Tests analytics

Total tests: 32
Passed tests: 30
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Nov 14, 2025

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_iamWorkforcePoolProviderScimTokenBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melinath melinath Awaiting requested review from melinath

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

service/iam-workforce

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaideoka @modular-magician