这是indexloc提供的服务,不要输入任何密码
Skip to content

Mark load_balancing_scheme field required. #14624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: FEATURE-BRANCH-major-release-7.0.0
Choose a base branch
from

Conversation

hao-nan-li
Copy link
Contributor

@hao-nan-li hao-nan-li commented Jul 24, 2025

fixes hashicorp/terraform-provider-google#18196

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networkservices: `load_balancing_scheme` field is now required in `google_network_services_lb_traffic_extension`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 22 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 3 files changed, 22 insertions(+), 16 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field load_balancing_scheme changed from optional to required on google_network_services_lb_traffic_extension - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@hao-nan-li hao-nan-li added the override-breaking-change Allows a potential breaking change to be merged label Jul 24, 2025
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 60
Passed tests: 59
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkservices
🟢 All tests passed!

View the build log

@hao-nan-li hao-nan-li marked this pull request as ready for review July 24, 2025 17:22
@hao-nan-li hao-nan-li requested a review from NickElliot July 24, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged service/networkservices-service-extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants