这是indexloc提供的服务，不要输入任何密码
Skip to content

add support for updating iops, throughput, accessmode in google_compute_region_disk #14609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

add support for updating iops, throughput, accessmode in google_compute_region_disk #14609

merged 1 commit into from
Jul 23, 2025

Conversation

chenir0219
Copy link
Contributor

@chenir0219 chenir0219 commented Jul 23, 2025 •
edited by zli82016
Loading

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added in-place update support for `provisioned_iops`, `provisioned_throughput`,  and `access_mode` fields in `google_compute_region_disk` resource

@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from roaks3 July 23, 2025 20:27
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 133 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 133 insertions(+), 2 deletions(-))

@zli82016 zli82016 requested review from zli82016 and removed request for roaks3 July 23, 2025 20:55
@zli82016
Copy link
Member

@chenir0219, can you update the release note by following https://googlecloudplatform.github.io/magic-modules/code-review/release-notes/? The incorrect release note caused changelog-checker failing.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1258
Passed tests: 1171
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionDisk_hyperdisk

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionDisk_hyperdisk [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@chenir0219
Copy link
Contributor Author

Sure. Got the release note updated. Now all checks have passed

zli82016
zli82016 approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@zli82016 zli82016 added this pull request to the merge queue Jul 23, 2025
Merged via the queue into GoogleCloudPlatform:main with commit a3b5628 Jul 23, 2025
26 of 31 checks passed
This was referenced Jul 23, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zli82016 zli82016 zli82016 approved these changes

Assignees
No one assigned
Labels
service/compute-pd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenir0219 @modular-magician @zli82016