Add Feature Service attachment tunneling config #14602
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Please format the changelog entry to match https://googlecloudplatform.github.io/magic-modules/code-review/release-notes/#type-specific-guidelines-and-examples
It should use snake_case for field names, and the resource name should match the resource name in Terraform rather than the API
| description: | | ||
| Tunneling configuration for this service attachment. | ||
| min_version: beta | ||
| ignore_read: true |
There was a problem hiding this comment.
Why do we need ignore read here?
| @@ -209,6 +236,21 @@ properties: | |||
| immutable: true | |||
| item_type: | |||
| type: String | |||
| - name: 'tunnelingConfig' | |||
There was a problem hiding this comment.
Please add an update test for this field
This PR adds tunnelingConfig to ServiceAttachment.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.