这是indexloc提供的服务,不要输入任何密码
Skip to content

Add capability related fields to the folder schema #14601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blacken57
Copy link

@blacken57 blacken57 commented Jul 23, 2025

Adds two new fields to the Folders Schema: configured_capabilities and management_project. These fields are populated when a capability is enabled on a Folder. A capability is enabled/disabled as part of a UpdateCapability call. These fields are output only and cannot be manipulated by directly updating the Folder.

Fixes b/422638425

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

resourcemanager: Added `management_project` and `configured_capabilities` fields to the `google_folder` resource.

@github-actions github-actions bot requested a review from BBBmau July 23, 2025 09:13
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 33 insertions(+))
google-beta provider: Diff ( 3 files changed, 59 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_folder (177 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_folder" "primary" {
  configured_capabilities = # value needed
  management_project      = # value needed
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_folder
    • Expected Document Path: /website/docs/r/google_folder.html.markdown
    • Fields: [configured_capabilities management_project]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 165
Passed tests: 134
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages
  • resourcemanager
  • resourcemanager3
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 24, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 33 insertions(+))
google-beta provider: Diff ( 3 files changed, 40 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_folder (177 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_folder" "primary" {
  configured_capabilities = # value needed
  management_project      = # value needed
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_folder
    • Expected Document Path: /website/docs/r/google_folder.html.markdown
    • Fields: [configured_capabilities management_project]

@@ -27,6 +30,10 @@ func TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic(t *
Steps: []resource.TestStep{
{
Config: testAccResourceManagerCapability_resourceManagerCapabilityExample_basic(context),
Check: resource.ComposeTestCheckFunc(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like the fields are never added into the test configuration which is why we see a missing test report

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_folder (177 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_folder" "primary" {
  configured_capabilities = # value needed
  management_project      = # value needed
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants