-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add capability related fields to the folder schema #14601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_folder" "primary" {
configured_capabilities = # value needed
management_project = # value needed
}
Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 165 Click here to see the affected service packages
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_folder" "primary" {
configured_capabilities = # value needed
management_project = # value needed
}
Missing doc report (experimental)The following resources have fields missing in documents.
|
@@ -27,6 +30,10 @@ func TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic(t * | |||
Steps: []resource.TestStep{ | |||
{ | |||
Config: testAccResourceManagerCapability_resourceManagerCapabilityExample_basic(context), | |||
Check: resource.ComposeTestCheckFunc( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like the fields are never added into the test configuration which is why we see a missing test report
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_folder
(177 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_folder" "primary" {
configured_capabilities = # value needed
management_project = # value needed
}
Adds two new fields to the Folders Schema: configured_capabilities and management_project. These fields are populated when a capability is enabled on a Folder. A capability is enabled/disabled as part of a UpdateCapability call. These fields are output only and cannot be manipulated by directly updating the Folder.
Fixes b/422638425
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.