这是indexloc提供的服务,不要输入任何密码
Skip to content

Add support for dataproc cluster_tier #14595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swainmoc
Copy link

@swainmoc swainmoc commented Jul 22, 2025

Added support for Dataproc cluster tier.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

dataproc: added `cluster_config.cluster_tier` field to `google_dataproc_cluster` resource

@github-actions github-actions bot requested a review from BBBmau July 22, 2025 12:36
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/dataproc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 22, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 88 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 88 insertions(+), 3 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field cluster_config.cluster_tier added as optional with a default value and force new on pre-existing resource google_dataproc_cluster. This can be allowed if there is a confirmed API-level default that matches the schema default - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_cluster (70 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_cluster" "primary" {
  cluster_config {
    cluster_tier   = # value needed
    staging_bucket = # value needed
    temp_bucket    = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 75
Passed tests: 18
Skipped tests: 5
Affected tests: 52

Click here to see the affected service packages
  • dataproc
#### Action taken
Found 52 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocAutoscalingPolicy_dataprocAutoscalingPolicyExample
  • TestAccDataprocBatch_dataprocBatchSparkFullExample
  • TestAccDataprocClusterIamBinding
  • TestAccDataprocClusterIamMember
  • TestAccDataprocClusterIamPolicy
  • TestAccDataprocCluster_KMS
  • TestAccDataprocCluster_nonPreemptibleSecondary
  • TestAccDataprocCluster_singleNodeCluster
  • TestAccDataprocCluster_spotOnDemandMixing
  • TestAccDataprocCluster_spotSecondary
  • TestAccDataprocCluster_spotWithAuxiliaryNodeGroups
  • TestAccDataprocCluster_spotWithInstanceFlexibilityPolicy
  • TestAccDataprocCluster_updatable
  • TestAccDataprocCluster_updateIdentityConfigUserMapping
  • TestAccDataprocCluster_withAccelerators
  • TestAccDataprocCluster_withAutoscalingPolicy
  • TestAccDataprocCluster_withClusterTier
  • TestAccDataprocCluster_withConfidentialCompute
  • TestAccDataprocCluster_withConfigOverrides
  • TestAccDataprocCluster_withDataprocMetricConfig
  • TestAccDataprocCluster_withEndpointConfig
  • TestAccDataprocCluster_withIdentityConfig
  • TestAccDataprocCluster_withImageVersion
  • TestAccDataprocCluster_withInitAction
  • TestAccDataprocCluster_withInternalIpOnlyTrueAndShieldedConfig
  • TestAccDataprocCluster_withKerberos
  • TestAccDataprocCluster_withLabels
  • TestAccDataprocCluster_withLifecycleConfigIdleDeleteTtl
  • TestAccDataprocCluster_withMetadataAndTags
  • TestAccDataprocCluster_withMetastoreConfig
  • TestAccDataprocCluster_withMinNumInstances
  • TestAccDataprocCluster_withNodeGroupAffinity
  • TestAccDataprocCluster_withOptionalComponents
  • TestAccDataprocCluster_withReservationAffinity
  • TestAccDataprocCluster_withServiceAcc
  • TestAccDataprocCluster_withShieldedConfig
  • TestAccDataprocCluster_withStagingBucket
  • TestAccDataprocCluster_withTempBucket
  • TestAccDataprocJobIamBinding
  • TestAccDataprocJobIamMember
  • TestAccDataprocJobIamPolicy
  • TestAccDataprocJob_Hadoop
  • TestAccDataprocJob_Hive
  • TestAccDataprocJob_Pig
  • TestAccDataprocJob_Presto
  • TestAccDataprocJob_PySpark
  • TestAccDataprocJob_Spark
  • TestAccDataprocJob_SparkSql_QueryFile
  • TestAccDataprocJob_SparkSql_QueryList
  • TestAccDataprocJob_updatable
  • TestAccDataprocSessionTemplate_dataprocSessionTemplatesJupyterFullExample
  • TestAccDataprocSessionTemplate_update

Get to know how VCR tests work

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll also want to make sure to add the new field in the update_tests, this is the reason why we get a missing test report from module-magician

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocAutoscalingPolicy_dataprocAutoscalingPolicyExample [Debug log]
TestAccDataprocBatch_dataprocBatchSparkFullExample [Debug log]
TestAccDataprocClusterIamBinding [Debug log]
TestAccDataprocClusterIamMember [Debug log]
TestAccDataprocClusterIamPolicy [Debug log]
TestAccDataprocCluster_KMS [Debug log]
TestAccDataprocCluster_nonPreemptibleSecondary [Debug log]
TestAccDataprocCluster_singleNodeCluster [Debug log]
TestAccDataprocCluster_spotOnDemandMixing [Debug log]
TestAccDataprocCluster_spotSecondary [Debug log]
TestAccDataprocCluster_spotWithAuxiliaryNodeGroups [Debug log]
TestAccDataprocCluster_spotWithInstanceFlexibilityPolicy [Debug log]
TestAccDataprocCluster_updatable [Debug log]
TestAccDataprocCluster_updateIdentityConfigUserMapping [Debug log]
TestAccDataprocCluster_withAccelerators [Debug log]
TestAccDataprocCluster_withAutoscalingPolicy [Debug log]
TestAccDataprocCluster_withConfidentialCompute [Debug log]
TestAccDataprocCluster_withConfigOverrides [Debug log]
TestAccDataprocCluster_withDataprocMetricConfig [Debug log]
TestAccDataprocCluster_withEndpointConfig [Debug log]
TestAccDataprocCluster_withIdentityConfig [Debug log]
TestAccDataprocCluster_withImageVersion [Debug log]
TestAccDataprocCluster_withInitAction [Debug log]
TestAccDataprocCluster_withInternalIpOnlyTrueAndShieldedConfig [Debug log]
TestAccDataprocCluster_withKerberos [Debug log]
TestAccDataprocCluster_withLabels [Debug log]
TestAccDataprocCluster_withLifecycleConfigIdleDeleteTtl [Debug log]
TestAccDataprocCluster_withMetadataAndTags [Debug log]
TestAccDataprocCluster_withMetastoreConfig [Debug log]
TestAccDataprocCluster_withMinNumInstances [Debug log]
TestAccDataprocCluster_withNodeGroupAffinity [Debug log]
TestAccDataprocCluster_withOptionalComponents [Debug log]
TestAccDataprocCluster_withReservationAffinity [Debug log]
TestAccDataprocCluster_withServiceAcc [Debug log]
TestAccDataprocCluster_withShieldedConfig [Debug log]
TestAccDataprocCluster_withStagingBucket [Debug log]
TestAccDataprocCluster_withTempBucket [Debug log]
TestAccDataprocJobIamBinding [Debug log]
TestAccDataprocJobIamMember [Debug log]
TestAccDataprocJobIamPolicy [Debug log]
TestAccDataprocJob_Hadoop [Debug log]
TestAccDataprocJob_Hive [Debug log]
TestAccDataprocJob_Pig [Debug log]
TestAccDataprocJob_Presto [Debug log]
TestAccDataprocJob_PySpark [Debug log]
TestAccDataprocJob_Spark [Debug log]
TestAccDataprocJob_SparkSql_QueryFile [Debug log]
TestAccDataprocJob_SparkSql_QueryList [Debug log]
TestAccDataprocJob_updatable [Debug log]
TestAccDataprocSessionTemplate_dataprocSessionTemplatesJupyterFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDataprocCluster_withClusterTier [Error message] [Debug log]
TestAccDataprocSessionTemplate_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@swainmoc
Copy link
Author

you'll also want to make sure to add the new field in the update_tests, this is the reason why we get a missing test report from module-magician

@BBBmau I am not seeing any update tests which contain both staging_bucket and temp_bucket. Do I need to add a new test?

@github-actions github-actions bot requested a review from BBBmau July 22, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants