这是indexloc提供的服务,不要输入任何密码
Skip to content

FEAT: Add support for Multi-Region Services in cloudrunv2 #14592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rafaeltello
Copy link
Contributor

@rafaeltello rafaeltello commented Jul 22, 2025

cloudrunv2: Add support for `multi_region_settings` field to `cloud_run_v2_service` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 153 insertions(+))
google-beta provider: Diff ( 4 files changed, 153 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (69 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  multi_region_settings {
    regions = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 81
Passed tests: 72
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • cloudrunv2
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 168 insertions(+))
google-beta provider: Diff ( 4 files changed, 168 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (70 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  multi_region_settings {
    regions = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 168 insertions(+))
google-beta provider: Diff ( 4 files changed, 168 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (70 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  multi_region_settings {
    regions = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 82
Passed tests: 72
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2MultiRegionService

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 82
Passed tests: 72
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2MultiRegionService

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2MultiRegionService [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2MultiRegionService [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 168 insertions(+))
google-beta provider: Diff ( 4 files changed, 168 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (70 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  multi_region_settings {
    regions = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 82
Passed tests: 72
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2MultiRegionService

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2MultiRegionService [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 168 insertions(+))
google-beta provider: Diff ( 4 files changed, 168 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (69 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  multi_region_settings {
    regions = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 82
Passed tests: 72
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2MultiRegionService

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2MultiRegionService [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 168 insertions(+))
google-beta provider: Diff ( 4 files changed, 168 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 82
Passed tests: 72
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2MultiRegionService

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2MultiRegionService [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 209 insertions(+))
google-beta provider: Diff ( 4 files changed, 209 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 82
Passed tests: 72
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2MultiRegionService

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2MultiRegionService [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants