Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 150 files changed, 20926 insertions(+), 535 deletions(-))
google-beta provider: Diff ( 155 files changed, 18629 insertions(+), 580 deletions(-))
terraform-google-conversion: Diff ( 70 files changed, 24517 insertions(+), 366 deletions(-))
Open in Cloud Shell: Diff ( 63 files changed, 1516 insertions(+), 49 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_analytics_hub_data_exchange_subscription (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_analytics_hub_data_exchange_subscription" "primary" {
  linked_dataset_map {
    resource_name = # value needed
  }
}

Resource: google_compute_region_url_map (60 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_url_map" "primary" {
  path_matcher {
    route_rules {
      route_action {
        request_mirror_policy {
          mirror_percent = # value needed
        }
      }
    }
  }
}

Resource: google_compute_reservation (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_reservation" "primary" {
  delete_after_duration {
    nanos = # value needed
  }
}

Resource: google_dialogflow_cx_webhook (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_webhook" "primary" {
  enable_spell_correction    = # value needed
  enable_stackdriver_logging = # value needed
  security_settings          = # value needed
}

Resource: google_gemini_gemini_gcp_enablement_setting (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_gemini_gcp_enablement_setting" "primary" {
  disable_web_grounding = # value needed
}

Resource: google_vertex_ai_endpoint_with_model_garden_deployment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_endpoint_with_model_garden_deployment" "primary" {
  deploy_config {
    dedicated_resources {
      autoscaling_metric_specs {
        metric_name = # value needed
        target      = # value needed
      }
      machine_spec {
        multihost_gpu_node_count = # value needed
        reservation_affinity {
          key                       = # value needed
          reservation_affinity_type = # value needed
          values                    = # value needed
        }
        tpu_topology = # value needed
      }
      max_replica_count      = # value needed
      required_replica_count = # value needed
      spot                   = # value needed
    }
    fast_tryout_enabled = # value needed
    system_labels       = # value needed
  }
  endpoint_config {
    dedicated_endpoint_enabled = # value needed
    endpoint_display_name      = # value needed
  }
  hugging_face_model_id = # value needed
  model_config {
    container_spec {
      args               = # value needed
      command            = # value needed
      deployment_timeout = # value needed
      env {
        name  = # value needed
        value = # value needed
      }
      grpc_ports {
        container_port = # value needed
      }
      health_probe {
        exec {
          command = # value needed
        }
        failure_threshold = # value needed
        grpc {
          port    = # value needed
          service = # value needed
        }
        http_get {
          host = # value needed
          http_headers {
            name  = # value needed
            value = # value needed
          }
          path   = # value needed
          port   = # value needed
          scheme = # value needed
        }
        initial_delay_seconds = # value needed
        period_seconds        = # value needed
        success_threshold     = # value needed
        tcp_socket {
          host = # value needed
          port = # value needed
        }
        timeout_seconds = # value needed
      }
      health_route = # value needed
      image_uri    = # value needed
      liveness_probe {
        exec {
          command = # value needed
        }
        failure_threshold = # value needed
        grpc {
          port    = # value needed
          service = # value needed
        }
        http_get {
          host = # value needed
          http_headers {
            name  = # value needed
            value = # value needed
          }
          path   = # value needed
          port   = # value needed
          scheme = # value needed
        }
        initial_delay_seconds = # value needed
        period_seconds        = # value needed
        success_threshold     = # value needed
        tcp_socket {
          host = # value needed
          port = # value needed
        }
        timeout_seconds = # value needed
      }
      ports {
        container_port = # value needed
      }
      predict_route         = # value needed
      shared_memory_size_mb = # value needed
      startup_probe {
        exec {
          command = # value needed
        }
        failure_threshold = # value needed
        grpc {
          port    = # value needed
          service = # value needed
        }
        http_get {
          host = # value needed
          http_headers {
            name  = # value needed
            value = # value needed
          }
          path   = # value needed
          port   = # value needed
          scheme = # value needed
        }
        initial_delay_seconds = # value needed
        period_seconds        = # value needed
        success_threshold     = # value needed
        tcp_socket {
          host = # value needed
          port = # value needed
        }
        timeout_seconds = # value needed
      }
    }
    hugging_face_access_token  = # value needed
    hugging_face_cache_enabled = # value needed
    model_display_name         = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_compute_preview_feature
• google_vertex_ai_endpoint_with_model_garden_deployment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_bigquery_analytics_hub_data_exchange_subscription, google_bigtable_schema_bundle, google_compute_preview_feature, google_dialogflow_cx_generator, google_gkeonprem_vmware_admin_cluster, google_model_armor_floorsetting, google_network_security_backend_authentication_config, google_vertex_ai_endpoint_with_model_garden_deployment. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_bigquery_table
  • Expected Document Path: /website/docs/r/bigquery_table.html.markdown
  • Fields: [ignore_auto_generated_schema]
• google_dataproc_cluster
  • Expected Document Path: /website/docs/r/dataproc_cluster.html.markdown
  • Fields: [cluster_config.security_config.identity_config.user_service_account_mapping]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionIDAndHivePartitioning
• TestAccBigtableSchemaBundle_bigtableSchemaBundleExample
• TestAccBigtableSchemaBundle_update
• TestAccComputeReservation_deleteAfterDuration
• TestAccComputeReservation_deleteAtTime
• TestAccComputeReservation_sharedReservationBetaExample

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccCloudRunV2Job_cloudrunv2JobGpuExample
• TestAccCloudRunV2Job_cloudrunv2JobWithGpuUpdate
• TestAccComputeBackendService_backendServiceTlsSettingsExample
• TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterBasicExample
• TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterFullExample
• TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterMetallbExample
• TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
• TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigBasicExample
• TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample
• TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample_update

Tests analytics

Total tests: 5321
Passed tests: 4702
Skipped tests: 592
Affected tests: 27

Get to know how VCR tests work

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_EmptyGuestAccelerator [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_resourceManagerTags [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test