-
Notifications
You must be signed in to change notification settings - Fork 1.9k
google_cloudfunctions_function base image policy fields #14552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloudfunctions_function" "primary" {
on_deploy_update_policy {
runtime_version = # value needed
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloudfunctions_function" "primary" {
on_deploy_update_policy {
runtime_version = # value needed
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 20 Click here to see the affected service packages
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 20 Click here to see the affected service packages
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
mmv1/third_party/terraform/services/cloudfunctions/resource_cloudfunctions_function.go
Show resolved
Hide resolved
.../third_party/terraform/services/cloudfunctions/resource_cloudfunctions_function_test.go.tmpl
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloudfunctions_function" "primary" {
on_deploy_update_policy {
runtime_version = # value needed
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 20 Click here to see the affected service packages
View the build log |
@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing test report (
on_deploy_update_policy.runtime_version
)
Missing doc report (on_deploy_update_policy.runtime_version
)
Please fix these, thanks!
mmv1/third_party/terraform/services/cloudfunctions/resource_cloudfunctions_function_meta.yaml
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/cloudfunctions/resource_cloudfunctions_function.go
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloudfunctions_function" "primary" {
on_deploy_update_policy {
runtime_version = # value needed
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 20 Click here to see the affected service packages
View the build log |
this should now have been fixed |
Tests analyticsTotal tests: 20 Click here to see the affected service packages
View the build log |
Tests analyticsTotal tests: 20 Click here to see the affected service packages
View the build log |
Adding 2 new fields to google_cloudfunctions_function (Cloud Function 1st gen) automatic_update_policy and on_deploy_update_policy (the former is the API default)