这是indexloc提供的服务,不要输入任何密码
Skip to content

google_cloudfunctions_function base image policy fields #14552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

dixuswe
Copy link
Contributor

@dixuswe dixuswe commented Jul 17, 2025

Adding 2 new fields to google_cloudfunctions_function (Cloud Function 1st gen) automatic_update_policy and on_deploy_update_policy (the former is the API default)

cloudfunction: added `automatic_update_policy` and `on_deploy_update_policy` to google_cloudfunctions_function resource

@github-actions github-actions bot requested a review from melinath July 17, 2025 00:09
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 271 insertions(+))
google-beta provider: Diff ( 4 files changed, 271 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloudfunctions_function (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloudfunctions_function" "primary" {
  on_deploy_update_policy {
    runtime_version = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_cloudfunctions_function
    • Expected Document Path: /website/docs/r/cloudfunctions_function.html.markdown
    • Fields: [on_deploy_update_policy.runtime_version]

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 271 insertions(+))
google-beta provider: Diff ( 4 files changed, 271 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloudfunctions_function (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloudfunctions_function" "primary" {
  on_deploy_update_policy {
    runtime_version = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_cloudfunctions_function
    • Expected Document Path: /website/docs/r/cloudfunctions_function.html.markdown
    • Fields: [on_deploy_update_policy.runtime_version]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 17
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • cloudfunctions
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsFunction_abiuCRUD

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 17
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • cloudfunctions
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsFunction_abiuCRUD

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudFunctionsFunction_abiuCRUD [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudFunctionsFunction_abiuCRUD [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 272 insertions(+))
google-beta provider: Diff ( 4 files changed, 272 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloudfunctions_function (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloudfunctions_function" "primary" {
  on_deploy_update_policy {
    runtime_version = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_cloudfunctions_function
    • Expected Document Path: /website/docs/r/cloudfunctions_function.html.markdown
    • Fields: [on_deploy_update_policy.runtime_version]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • cloudfunctions
🟢 All tests passed!

View the build log

Copy link

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test report (on_deploy_update_policy.runtime_version)
Missing doc report (on_deploy_update_policy.runtime_version)

Please fix these, thanks!

@github-actions github-actions bot requested a review from melinath July 25, 2025 16:54
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 272 insertions(+))
google-beta provider: Diff ( 4 files changed, 272 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloudfunctions_function (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloudfunctions_function" "primary" {
  on_deploy_update_policy {
    runtime_version = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_cloudfunctions_function
    • Expected Document Path: /website/docs/r/cloudfunctions_function.html.markdown
    • Fields: [on_deploy_update_policy.runtime_version]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • cloudfunctions
🟢 All tests passed!

View the build log

@dixuswe
Copy link
Contributor Author

dixuswe commented Jul 25, 2025

Missing test report (on_deploy_update_policy.runtime_version)
Missing doc report (on_deploy_update_policy.runtime_version)

Please fix these, thanks!

this should now have been fixed

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 275 insertions(+))
google-beta provider: Diff ( 4 files changed, 275 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 271 insertions(+))
google-beta provider: Diff ( 4 files changed, 271 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • cloudfunctions
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • cloudfunctions
🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants