这是indexloc提供的服务，不要输入任何密码
Skip to content

Update dataproc Batch and dataproc SessionTemplate resource to support authentication config. #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 18, 2025
Merged

Update dataproc Batch and dataproc SessionTemplate resource to support authentication config. #14534

merged 11 commits into from
Jul 18, 2025

Conversation

animeshnandanwar
Copy link
Contributor

@animeshnandanwar animeshnandanwar commented Jul 15, 2025 •
edited
Loading

Update dataproc Batch and dataproc SessionTemplate resource to support authentication config.
The API reference is still not updated, but WIP.

dataproc: added `authentication_config` field to `google_dataproc_batch` and `google_dataproc_session_template` resource

@github-actions github-actions bot requested a review from shuyama1 July 15, 2025 19:36
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 184 insertions(+))
google-beta provider: Diff ( 8 files changed, 184 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 60 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 65
Skipped tests: 5
Affected tests: 4

Click here to see the affected service packages
  • dataproc
#### Action taken
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocBatch_dataprocBatchSparkExample
  • TestAccDataprocBatch_dataprocBatchSparkFullExample
  • TestAccDataprocSessionTemplate_dataprocSessionTemplatesJupyterExample
  • TestAccDataprocSessionTemplate_dataprocSessionTemplatesJupyterFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 184 insertions(+))
google-beta provider: Diff ( 8 files changed, 184 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 60 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 65
Skipped tests: 5
Affected tests: 4

Click here to see the affected service packages
  • dataproc
#### Action taken
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocBatch_dataprocBatchSparkExample
  • TestAccDataprocBatch_dataprocBatchSparkFullExample
  • TestAccDataprocSessionTemplate_dataprocSessionTemplatesJupyterExample
  • TestAccDataprocSessionTemplate_dataprocSessionTemplatesJupyterFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 184 insertions(+))
google-beta provider: Diff ( 8 files changed, 184 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 60 insertions(+))

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocBatch_dataprocBatchSparkFullExample [Debug log]
TestAccDataprocSessionTemplate_dataprocSessionTemplatesJupyterExample [Debug log]
TestAccDataprocSessionTemplate_dataprocSessionTemplatesJupyterFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataprocBatch_dataprocBatchSparkExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 68
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • dataproc
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocBatch_dataprocBatchSparkExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocBatch_dataprocBatchSparkExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 178 insertions(+))
google-beta provider: Diff ( 8 files changed, 178 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 60 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 69
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • dataproc
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocBatch_dataprocBatchSparkFullExample [Debug log]
TestAccDataprocSessionTemplate_dataprocSessionTemplatesJupyterExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataprocBatch_dataprocBatchSparkExample [Error message] [Debug log]
TestAccDataprocSessionTemplate_dataprocSessionTemplatesJupyterFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

shuyama1
shuyama1 reviewed Jul 17, 2025
View reviewed changes
animeshnandanwar and others added 2 commits July 17, 2025 11:07
@animeshnandanwar @shuyama1
Remove AUTHENTICATION_TYPE_UNSPECIFIED
56997e5 
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
@animeshnandanwar @shuyama1
Remove AUTHENTICATION_TYPE_UNSPECIFIED from batches
f1e07c5 
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
@github-actions github-actions bot requested a review from shuyama1 July 17, 2025 18:08
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 178 insertions(+))
google-beta provider: Diff ( 8 files changed, 178 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 60 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 178 insertions(+))
google-beta provider: Diff ( 8 files changed, 178 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 60 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 69
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • dataproc
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 69
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • dataproc
🟢 All tests passed!

View the build log

@shuyama1 shuyama1 added this pull request to the merge queue Jul 18, 2025
Merged via the queue into GoogleCloudPlatform:main with commit a706c4f Jul 18, 2025
26 checks passed
This was referenced Jul 18, 2025
Merged
Merged
Merged
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 21, 2025
@animeshnandanwar @shuyama1 @BBBmau
Update dataproc Batch and dataproc SessionTemplate resource to suppor…
8414095 
…t authentication config. (GoogleCloudPlatform#14534)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 21, 2025
@animeshnandanwar @shuyama1 @BBBmau
Update dataproc Batch and dataproc SessionTemplate resource to suppor…
17664e9 
…t authentication config. (GoogleCloudPlatform#14534)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuyama1 shuyama1 shuyama1 approved these changes

Assignees
No one assigned
Labels
service/dataproc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@animeshnandanwar @modular-magician @shuyama1