这是indexloc提供的服务,不要输入任何密码
Skip to content

Router tags at creation #14527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 23, 2025
Merged

Conversation

Gorlami96
Copy link
Contributor

@Gorlami96 Gorlami96 commented Jul 15, 2025

Router tagging at creation Hz - b/323924842
Release Note Template for Downstream PRs (will be copied)

compute: add `params.resourceManagerTags` field to the `google_compute_router`

@github-actions github-actions bot requested a review from rileykarson July 15, 2025 09:32
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 114 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 174 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 114 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 174 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1255
Passed tests: 1168
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1255
Passed tests: 1168
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 45 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 172 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 44 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 172 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1255
Passed tests: 1168
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1255
Passed tests: 1168
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from rileykarson July 16, 2025 11:40
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 138 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1256
Passed tests: 1169
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 138 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1256
Passed tests: 1169
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 141 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1258
Passed tests: 1171
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 141 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1258
Passed tests: 1171
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from rileykarson July 18, 2025 10:56
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 140 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1258
Passed tests: 1171
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 140 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1258
Passed tests: 1171
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@Gorlami96
Copy link
Contributor Author

@rileykarson can you PTAL?

Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rileykarson rileykarson added this pull request to the merge queue Jul 23, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 6789373 Jul 23, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants