Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

This PR will allow terraform to add or remove instances to linked_router_appliance_instances without requiring deletion of the existing spoke. This behavior aligns with how the gcloud and console behave

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 50 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 50 insertions(+), 4 deletions(-))

Tests analytics

Total tests: 39
Passed tests: 36
Skipped tests: 1
Affected tests: 2

Get to know how VCR tests work

🟢 Tests passed during RECORDING mode:
TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten [Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

LGTM

Is there a GitHub issue we should tie this to before we merge?

There is no issue, I noticed the issue during a deployment and it was quicker to fix