这是indexloc提供的服务,不要输入任何密码
Skip to content

feat: Add resource google_oracle_database_odb_network #14576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nimish-khurana
Copy link
Contributor

@nimish-khurana nimish-khurana commented Jul 19, 2025

ref hashicorp/terraform-provider-google#23651

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_oracle_database_odb_network`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from ScottSuarez July 19, 2025 09:04
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 19, 2025
@nimish-khurana nimish-khurana changed the title feat: Add resource google_oracledatabase_odb_network feat: Add resource google_oracle_database_odb_network Jul 19, 2025
@modular-magician modular-magician added service/oracledatabase and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 19, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 755 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 755 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_odb_network (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_odb_network" "primary" {
  labels = # value needed
}

@nimish-khurana nimish-khurana force-pushed the feature/add_resource_google_oracledatabase_odb_network branch from bcc29ac to 58d82ab Compare July 19, 2025 09:48
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • oracledatabase
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseOdbNetwork_oracledatabaseOdbnetworkExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseOdbNetwork_oracledatabaseOdbnetworkExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 755 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 755 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_odb_network (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_odb_network" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • oracledatabase
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseOdbNetwork_oracledatabaseOdbnetworkExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseOdbNetwork_oracledatabaseOdbnetworkExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 759 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 759 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 759 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 759 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase
🟢 All tests passed!

View the build log

@nimish-khurana nimish-khurana force-pushed the feature/add_resource_google_oracledatabase_odb_network branch from acd30e7 to f6657db Compare July 21, 2025 08:13
@nimish-khurana nimish-khurana force-pushed the feature/add_resource_google_oracledatabase_odb_network branch from f6657db to 19542f8 Compare July 21, 2025 10:53
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 759 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 759 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase
🟢 All tests passed!

View the build log

@github-actions github-actions bot requested a review from ScottSuarez July 22, 2025 07:46
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 765 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 765 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase
🟢 All tests passed!

View the build log

@github-actions github-actions bot requested a review from ScottSuarez July 22, 2025 16:23
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 762 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 762 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 88 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase
🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants