这是indexloc提供的服务,不要输入任何密码
Skip to content

Remove token from github repo string if not necessary #14589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

iyabchen
Copy link
Contributor

@iyabchen iyabchen commented Jul 21, 2025

hashicorp/terraform-provider-google#17307

  • Clone does not require a token, but generate downstream diff(involves git commit) needs a token.
  • Tested in Test rm git token #14597 where a downstream can be generated.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@iyabchen iyabchen force-pushed the rm-git-token branch 2 times, most recently from ac002fa to 4ed7ff5 Compare July 22, 2025 00:17
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1257
Passed tests: 1171
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages
  • compute
🟢 All tests passed!

View the build log

@iyabchen iyabchen changed the title test remove token Remove token from github repo string if not necessary Jul 22, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@iyabchen iyabchen requested a review from shuyama1 July 22, 2025 22:41
@iyabchen iyabchen marked this pull request as ready for review July 22, 2025 22:41
@shuyama1 shuyama1 requested review from a team and ScottSuarez and removed request for shuyama1 and a team July 24, 2025 17:30
@shuyama1
Copy link
Member

Trying to rotate a reviewer from the contribution team, but it doesn't seem terraform-contribution exists anymore. Use terraform-validator-reviewers instead, as it seems to be the closest match

@ScottSuarez
Copy link
Contributor

I commented on this parent bug but i think we should always use a token when interacting with github. Even if we are using a public GET operation we might get hit with a 429.

@ScottSuarez
Copy link
Contributor

closing as of hashicorp/terraform-provider-google#17307 (comment)

@melinath

Thanks @iyabchen for taking a look, sorry for any throw away here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants