Remove extra step #14584
Open
Remove extra step #14584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests analyticsTotal tests: 52 Click here to see the affected service packages
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
melinath
requested changes
Jul 22, 2025
There was a problem hiding this comment.
This seems like something that should be possible to do, though? It looks like a bug in the test - for some reason google_bigquery_table isn't updated before the google_bigquery_connection is deleted. Possibly routing through the locals is breaking the ordering somehow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes extra step that is causing tests to fail due to deleted connection. I'm not sure why the second step was added here, it seems like it was copied from a test designed around removing the connection. I don't think it needs to exist
Tested locally
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.