这是indexloc提供的服务，不要输入任何密码
Skip to content

compute: fix documentation naming conflict, added network_name to data source google_compute_subnetworks and deprecated network_self_link #14583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

compute: fix documentation naming conflict, added network_name to data source google_compute_subnetworks and deprecated network_self_link #14583

wants to merge 3 commits into from
+8 −0

Conversation

ramonvermeulen
Copy link
Contributor

@ramonvermeulen ramonvermeulen commented Jul 21, 2025 •
edited
Loading

Closes hashicorp/terraform-provider-google#23663

Fixing it this way seems most logical to me, just in-case network_self_link is used even though not documented, so that there will be no breaking change in a 6.x.x release.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fix documentation naming conflict, added `network_name` to data source `google_compute_subnetworks` and deprecated `network_self_link`

@github-actions github-actions bot requested a review from shuyama1 July 21, 2025 09:15
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@ramonvermeulen ramonvermeulen mentioned this pull request Jul 21, 2025
Open
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 21, 2025
@ramonvermeulen ramonvermeulen changed the title compute: fix documentation naming conflict, added network_name to data source google_compute_subnetworks and deprecate network_self_link compute: fix documentation naming conflict, added network_name to data source google_compute_subnetworks and deprecated network_self_link Jul 21, 2025
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 21, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1199
Passed tests: 1113
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages
  • compute
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@github-actions github-actions bot requested a review from shuyama1 July 22, 2025 08:48
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 22, 2025
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 24, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 8 insertions(+))
google-beta provider: Diff ( 2 files changed, 8 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1258
Passed tests: 1172
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages
  • compute
🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuyama1 shuyama1 Awaiting requested review from shuyama1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
service/compute-vpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_compute_subnetworks data source has no attribute network_name
3 participants
@ramonvermeulen @modular-magician @shuyama1