这是indexloc提供的服务，不要输入任何密码
Skip to content

Adding support for refresh subscription resource. #14581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding support for refresh subscription resource. #14581

wants to merge 1 commit into from

Conversation

arnavdham
Copy link
Contributor

@arnavdham arnavdham commented Jul 21, 2025 •
edited
Loading

This Pull Request introduces a new resource refresh resource for Analytics Hub. This resource is made for calling the Refresh API which is an important API for the subscription resource.

`google_bigquery_analytics_hub_refresh_data_exchange_subscription` (beta)

@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from melinath July 21, 2025 08:32
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 186 insertions(+))
google-beta provider: Diff ( 5 files changed, 506 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 59 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • bigqueryanalyticshub
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryAnalyticsHubRefreshDataExchangeSubscription_bigqueryAnalyticshubRefreshDataexchangeSubscriptionExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBigqueryAnalyticsHubRefreshDataExchangeSubscription_bigqueryAnalyticshubRefreshDataexchangeSubscriptionExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

melinath
melinath reviewed Jul 22, 2025
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an imperative action; I'm not sure it makes sense to add to the Terraform provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath left review comments

@sachinpro sachinpro Awaiting requested review from sachinpro

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
service/bigquery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnavdham @modular-magician @melinath