这是indexloc提供的服务，不要输入任何密码
Skip to content

Add new field instanceLifecyclePolicy.onRepair.allowChangingZone to google_compute_region_instance_group_manager & google_compute_instance_group_manager #14580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add new field instanceLifecyclePolicy.onRepair.allowChangingZone to google_compute_region_instance_group_manager & google_compute_instance_group_manager #14580

wants to merge 1 commit into from

Conversation

chayankumar999
Copy link
Contributor

@chayankumar999 chayankumar999 commented Jul 21, 2025 •
edited
Loading

Add instanceLifecyclePolicy.onRepair.allowChangingZone to google_compute_region_instance_group_manager & google_compute_instance_group_manager for beta api.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Add new field instanceLifecyclePolicy.onRepair.allowChangingZone to google_compute_region_instance_group_manager & google_compute_instance_group_manager

@github-actions github-actions bot requested a review from melinath July 21, 2025 06:16
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@chayankumar999
add instance_life_cycle_policy.on_repair.allow_changing_zone to googl…
6b6589a 
…e_compute_region_instance_group_manager & google_compute_instance_group_manager
@chayankumar999 chayankumar999 marked this pull request as draft July 21, 2025 06:21
@chayankumar999 chayankumar999 changed the title add new field instance_life_cycle_policy.on_repair.allow_changing_zone to google_compute_region_instance_group_manager & google_compute_instance_group_manager Add new field instanceLifecyclePolicy.onRepair.allowChangingZone to google_compute_region_instance_group_manager & google_compute_instance_group_manager Jul 21, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 35 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 107 insertions(+), 3 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_compute_instance_group_manager
    • Expected Document Path: /website/docs/r/compute_instance_group_manager.html.markdown
    • Fields: [instance_lifecycle_policy.on_repair instance_lifecycle_policy.on_repair.allow_changing_zone]
  • google_compute_region_instance_group_manager
    • Expected Document Path: /website/docs/r/compute_region_instance_group_manager.html.markdown
    • Fields: [instance_lifecycle_policy.on_repair instance_lifecycle_policy.on_repair.allow_changing_zone]

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 35 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 110 insertions(+), 3 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_compute_instance_group_manager
    • Expected Document Path: /website/docs/r/compute_instance_group_manager.html.markdown
    • Fields: [instance_lifecycle_policy.on_repair instance_lifecycle_policy.on_repair.allow_changing_zone]
  • google_compute_region_instance_group_manager
    • Expected Document Path: /website/docs/r/compute_region_instance_group_manager.html.markdown
    • Fields: [instance_lifecycle_policy.on_repair instance_lifecycle_policy.on_repair.allow_changing_zone]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1257
Passed tests: 1166
Skipped tests: 86
Affected tests: 5

Click here to see the affected service packages
  • compute
#### Action taken
Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample
  • TestAccComputeResizeRequest_computeMigResizeRequestExample
  • TestAccInstanceGroupManager_update
  • TestAccInstanceGroupManager_waitForStatus
  • TestAccRegionInstanceGroupManager_update

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1257
Passed tests: 1166
Skipped tests: 86
Affected tests: 5

Click here to see the affected service packages
  • compute
#### Action taken
Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample
  • TestAccComputeResizeRequest_computeMigResizeRequestExample
  • TestAccInstanceGroupManager_update
  • TestAccInstanceGroupManager_waitForStatus
  • TestAccRegionInstanceGroupManager_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample [Debug log]
TestAccComputeResizeRequest_computeMigResizeRequestExample [Debug log]
TestAccInstanceGroupManager_waitForStatus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccInstanceGroupManager_update [Error message] [Debug log]
TestAccRegionInstanceGroupManager_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample [Debug log]
TestAccComputeResizeRequest_computeMigResizeRequestExample [Debug log]
TestAccInstanceGroupManager_waitForStatus [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccInstanceGroupManager_update [Error message] [Debug log]
TestAccRegionInstanceGroupManager_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

pjotrekk
pjotrekk approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@pjotrekk pjotrekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjotrekk pjotrekk pjotrekk approved these changes

@melinath melinath Awaiting requested review from melinath

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
service/compute-managed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chayankumar999 @modular-magician @pjotrekk