这是indexloc提供的服务,不要输入任何密码
Skip to content

Add deletion_protection field to Metastore Service #14455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rajeshgupthar
Copy link
Contributor

@rajeshgupthar rajeshgupthar commented Jul 4, 2025

Add deletion_protection field to make deletion actions require an explicit intent
Part of b/366197455

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

metastore: added `deletion_protection` field to the `dataproc_metastore_service` resource to prevent accidental deletion

Request mandatory review by @aniket-gupta

@github-actions github-actions bot requested a review from hao-nan-li July 4, 2025 04:53
Copy link

github-actions bot commented Jul 4, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
google-beta provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_protection default value changed from <nil> to false on google_dataproc_metastore_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
google-beta provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_protection default value changed from <nil> to false on google_dataproc_metastore_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 0
Skipped tests: 2
Affected tests: 6

Click here to see the affected service packages
  • dataprocmetastore
#### Action taken
Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocMetastoreServiceIamBindingGenerated
  • TestAccDataprocMetastoreServiceIamMemberGenerated
  • TestAccDataprocMetastoreServiceIamPolicyGenerated
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample
  • TestAccDataprocMetastoreService_updateAndImport
  • TestAccDataprocMetastoreService_updateLocation_deletionProtection

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocMetastoreServiceIamBindingGenerated [Error message] [Debug log]
TestAccDataprocMetastoreServiceIamMemberGenerated [Error message] [Debug log]
TestAccDataprocMetastoreServiceIamPolicyGenerated [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample [Error message] [Debug log]
TestAccDataprocMetastoreService_updateAndImport [Error message] [Debug log]
TestAccDataprocMetastoreService_updateLocation_deletionProtection [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 0
Skipped tests: 2
Affected tests: 6

Click here to see the affected service packages
  • dataprocmetastore
#### Action taken
Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocMetastoreServiceIamBindingGenerated
  • TestAccDataprocMetastoreServiceIamMemberGenerated
  • TestAccDataprocMetastoreServiceIamPolicyGenerated
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample
  • TestAccDataprocMetastoreService_updateAndImport
  • TestAccDataprocMetastoreService_updateLocation_deletionProtection

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocMetastoreServiceIamBindingGenerated [Error message] [Debug log]
TestAccDataprocMetastoreServiceIamMemberGenerated [Error message] [Debug log]
TestAccDataprocMetastoreServiceIamPolicyGenerated [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample [Error message] [Debug log]
TestAccDataprocMetastoreService_updateAndImport [Error message] [Debug log]
TestAccDataprocMetastoreService_updateLocation_deletionProtection [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

github-actions bot commented Jul 8, 2025

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
google-beta provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_protection default value changed from <nil> to false on google_dataproc_metastore_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 0
Skipped tests: 2
Affected tests: 6

Click here to see the affected service packages
  • dataprocmetastore
#### Action taken
Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocMetastoreServiceIamBindingGenerated
  • TestAccDataprocMetastoreServiceIamMemberGenerated
  • TestAccDataprocMetastoreServiceIamPolicyGenerated
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample
  • TestAccDataprocMetastoreService_updateAndImport
  • TestAccDataprocMetastoreService_updateLocation_deletionProtection

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocMetastoreServiceIamBindingGenerated [Error message] [Debug log]
TestAccDataprocMetastoreServiceIamMemberGenerated [Error message] [Debug log]
TestAccDataprocMetastoreServiceIamPolicyGenerated [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample [Error message] [Debug log]
TestAccDataprocMetastoreService_updateAndImport [Error message] [Debug log]
TestAccDataprocMetastoreService_updateLocation_deletionProtection [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
google-beta provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_protection default value changed from <nil> to false on google_dataproc_metastore_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
google-beta provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_protection default value changed from <nil> to false on google_dataproc_metastore_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccDataprocMetastoreService_deletionProtection

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataprocmetastore
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccDataprocMetastoreService_deletionProtection

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataprocmetastore
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

Copy link

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
google-beta provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_protection default value changed from <nil> to false on google_dataproc_metastore_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
google-beta provider: Diff ( 6 files changed, 74 insertions(+), 237 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_protection default value changed from <nil> to false on google_dataproc_metastore_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 0
Skipped tests: 2
Affected tests: 5

Click here to see the affected service packages
  • dataprocmetastore
#### Action taken
Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocMetastoreServiceIamBindingGenerated
  • TestAccDataprocMetastoreServiceIamMemberGenerated
  • TestAccDataprocMetastoreServiceIamPolicyGenerated
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample
  • TestAccDataprocMetastoreService_deletionProtection

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 0
Skipped tests: 2
Affected tests: 5

Click here to see the affected service packages
  • dataprocmetastore
#### Action taken
Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocMetastoreServiceIamBindingGenerated
  • TestAccDataprocMetastoreServiceIamMemberGenerated
  • TestAccDataprocMetastoreServiceIamPolicyGenerated
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample
  • TestAccDataprocMetastoreService_deletionProtection

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocMetastoreServiceIamBindingGenerated [Error message] [Debug log]
TestAccDataprocMetastoreServiceIamMemberGenerated [Error message] [Debug log]
TestAccDataprocMetastoreServiceIamPolicyGenerated [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocMetastoreServiceIamBindingGenerated [Error message] [Debug log]
TestAccDataprocMetastoreServiceIamMemberGenerated [Error message] [Debug log]
TestAccDataprocMetastoreServiceIamPolicyGenerated [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@SamanthaMathews
Copy link

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants