Add terraform support for Developer Connect Insights #14412

ishamiGIT · 2025-06-30T17:05:37Z

This PR adds the necessary configuration files and examples to enable Terraform users to manage their Developer Connect Insights resource.

Specifically, this PR:

Adds the InsightsConfig.yaml file to define the resource.
Includes a basic Terraform example.
Adds a create and update test case for the resource.

Addresses hashicorp/terraform-provider-google#23455

`google_developer_connect_insights_config`

github-actions · 2025-06-30T17:06:35Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-06-30T17:17:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1910 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1910 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  annotations = # value needed
  artifact_configs {
    google_artifact_analysis {
      project_id = # value needed
    }
    google_artifact_registry {
      artifact_registry_package = # value needed
      project_id                = # value needed
    }
  }
  labels = # value needed
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-06-30T17:20:52Z

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample

TestAccDeveloperConnectInsightsConfig_update

Get to know how VCR tests work

modular-magician · 2025-06-30T17:21:07Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2025-07-03T09:44:16Z

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-07-07T09:44:50Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

ishamiGIT · 2025-07-08T13:30:12Z

@rileykarson, please take a look to review my changes when you get the chance.

melinath · 2025-07-09T16:22:33Z

Notes from offline discussion:

This test needs to create a test project: https://googlecloudplatform.github.io/magic-modules/test/test/#create-test-projects
From debug logs, looks like API response doesn’t include a value for labels. Assuming this is not an API bug, the fix is adding ignore_read to the labels field: https://googlecloudplatform.github.io/magic-modules/reference/field/#ignore_read
- More details on diffs: https://googlecloudplatform.github.io/magic-modules/develop/diffs/

added ingore_read to labels

ishamiGIT · 2025-07-09T17:21:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1910 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 7 files changed, 1910 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:
resource "google_developer_connect_insights_config" "primary" {
  annotations = # value needed
  artifact_configs {
    google_artifact_analysis {
      project_id = # value needed
    }
    google_artifact_registry {
      artifact_registry_package = # value needed
      project_id                = # value needed
    }
  }
  labels = # value needed
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

Didn't add "runtime_config" field because of this error when running the test:
Can't configure a value for "runtime_configs": its value will be decided
| automatically based on the result of applying this configuration.

modular-magician · 2025-07-09T17:31:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1899 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1899 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-07-09T17:34:32Z

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample

TestAccDeveloperConnectInsightsConfig_update

Get to know how VCR tests work

modular-magician · 2025-07-09T17:34:48Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/templates/terraform/examples/developer_connect_insights_config_basic.tf.tmpl

mmv1/products/developerconnect/InsightsConfig.yaml

mmv1/openapi_generate/openapi/developerconnect_public_openapi3_0_v1.json

...party/terraform/services/developerconnect/resource_developer_connect_insights_config_test.go

mmv1/products/developerconnect/InsightsConfig.yaml

modular-magician · 2025-07-11T17:51:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1899 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1899 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-07-11T17:54:23Z

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample

TestAccDeveloperConnectInsightsConfig_update

Get to know how VCR tests work

modular-magician · 2025-07-11T17:54:40Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-14T14:58:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1899 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1899 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-07-14T15:01:39Z

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample

TestAccDeveloperConnectInsightsConfig_update

Get to know how VCR tests work

modular-magician · 2025-07-14T15:01:55Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

rileykarson · 2025-07-14T19:45:59Z

mmv1/products/developerconnect/InsightsConfig.yaml

+      insights_config_name: 'tf_test_ic'
+    test_env_vars:
+      project: 'PROJECT_NAME'
+      appHubApplication: 'APPHUB_APP_NAME'


Suggested change

appHubApplication: 'APPHUB_APP_NAME'

You can use a vars entry for this one!

rileykarson · 2025-07-14T19:46:52Z

mmv1/products/developerconnect/InsightsConfig.yaml

+  - projects/{{project}}/locations/{{location}}/insightsConfigs/{{insights_config_id}}
+examples:
+  - !ruby/object:Provider::Terraform::Examples
+    name: 'developer_connect_insights_config_basic'


This test won't currently pass, as the config is a stub. I'd recommend we create a complete example including dependencies like the app hub application, similar to the handwritten tests. This is standard for Terraform docs.

mmv1/products/developerconnect/InsightsConfig.yaml

rileykarson · 2025-07-14T19:50:10Z

...party/terraform/services/developerconnect/resource_developer_connect_insights_config_test.go

+func testAccDeveloperConnectInsightsConfig_basic(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+	data "google_project" "project" {
+	  project_id = "devconnect-insights-terraform"


We'll want the test to be as self-contained as possible.

Are there bootstrapping steps performed in this project we can do as part of the test?

If not, can we make them against the test environments (We support applying Terraform or running Go code for bootstrapping envs)?

If we do need an externally managed project we'll need to discuss managing some things like service account (test runner) permissions offline.

rileykarson · 2025-07-14T19:50:46Z

...party/terraform/services/developerconnect/resource_developer_connect_insights_config_test.go

+		artifact_configs {
+			uri = "us-docker.pkg.dev/my-project/my-repo/other-image"
+			google_artifact_analysis {
+                project_id = "devconnect-insights-terraform"


nit: use tabs on the left side here

Don't know why it's showing up like this here, from my editor it has the correct indentations? Retrying now, hopefully it works.

…ject

modular-magician · 2025-07-24T15:09:34Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-24T17:33:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2312 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2312 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  artifact_configs {
    google_artifact_analysis {
      project_id = # value needed
    }
    google_artifact_registry {
      artifact_registry_package = # value needed
      project_id                = # value needed
    }
    uri = # value needed
  }
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-07-24T17:35:59Z

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample

TestAccDeveloperConnectInsightsConfig_update

Get to know how VCR tests work

modular-magician · 2025-07-24T17:41:08Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-24T18:42:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2344 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2344 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  artifact_configs {
    google_artifact_analysis {
      project_id = # value needed
    }
    google_artifact_registry {
      artifact_registry_package = # value needed
      project_id                = # value needed
    }
    uri = # value needed
  }
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-07-24T18:45:43Z

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample

TestAccDeveloperConnectInsightsConfig_update

Get to know how VCR tests work

modular-magician · 2025-07-24T18:51:08Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-24T19:17:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2344 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2344 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  artifact_configs {
    google_artifact_analysis {
      project_id = # value needed
    }
    google_artifact_registry {
      artifact_registry_package = # value needed
      project_id                = # value needed
    }
    uri = # value needed
  }
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-07-24T19:20:12Z

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample

TestAccDeveloperConnectInsightsConfig_update

Get to know how VCR tests work

modular-magician · 2025-07-24T19:26:18Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-25T15:42:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2344 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2344 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  artifact_configs {
    google_artifact_analysis {
      project_id = # value needed
    }
    google_artifact_registry {
      artifact_registry_package = # value needed
      project_id                = # value needed
    }
    uri = # value needed
  }
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-07-25T15:45:25Z

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample

TestAccDeveloperConnectInsightsConfig_update

Get to know how VCR tests work

modular-magician · 2025-07-25T15:51:01Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-25T16:18:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2373 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2373 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-07-25T16:21:55Z

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample

TestAccDeveloperConnectInsightsConfig_update

Get to know how VCR tests work

modular-magician · 2025-07-25T16:27:59Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-25T17:19:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2373 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2373 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-07-25T17:22:53Z

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample

TestAccDeveloperConnectInsightsConfig_update

Get to know how VCR tests work

modular-magician · 2025-07-25T17:29:14Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Debug log]
TestAccDeveloperConnectInsightsConfig_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample [Error message] [Debug log]
TestAccDeveloperConnectInsightsConfig_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

rileykarson · 2025-07-25T17:57:19Z

...party/terraform/services/developerconnect/resource_developer_connect_insights_config_test.go

+	}
+	
+	# Grant Permissions
+	resource "google_project_iam_member" "apphub_permissions" {


Our presubmit "VCR" tests will be inconsistent due to having multiple resources of the same kind at the same level in the test's resource graph. This isn't an issue with the test or a "real" failure, just a deficiency in the presubmits. Can you skip both the handwritten and generated tests per https://googlecloudplatform.github.io/magic-modules/test/test/#skip-vcr?

They'll get executed in nightlies or can be kicked one-off, just not as automatic presubmits.

Ok, I added the skips for the generated and handwritten tests.

modular-magician · 2025-07-25T18:23:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2375 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2375 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 208 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_insights_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_insights_config" "primary" {
  runtime_configs {
    gke_workload {
      cluster = # value needed
    }
    uri = # value needed
  }
}

modular-magician · 2025-07-25T18:27:04Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccDeveloperConnectInsightsConfig_developerConnectInsightsConfigBasicExample
TestAccDeveloperConnectInsightsConfig_update

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

developerconnect

🟢 All tests passed!

View the build log

Add terraform support for Developer Connect Insights

cfa34b4

github-actions bot requested a review from rileykarson June 30, 2025 17:06

modular-magician added the service/developerconnect label Jun 30, 2025

Add terraform support for Developer Connect Insights

62549a4

added ingore_read to labels

rileykarson reviewed Jul 10, 2025

View reviewed changes

mmv1/templates/terraform/examples/developer_connect_insights_config_basic.tf.tmpl Outdated Show resolved Hide resolved

rileykarson reviewed Jul 10, 2025

View reviewed changes

fix: Addressed PR reviewer feedback

8d6f760

github-actions bot requested a review from rileykarson July 11, 2025 17:39

fix: Addressed lint warnings

695f59a

rileykarson reviewed Jul 14, 2025

View reviewed changes

fix: Testing after granting google identity direct permissions to pro…

a2de041

…ject

github-actions bot requested a review from rileykarson July 15, 2025 18:18

testing: adding apis/permissions for insights config 0.2

c95ee85

testing: adding disable_dependent_services arg

c00b26b

testing: match yaml primary_resource_id with test config

96d6cf2

testing: fix ResourceName in test config

7f8022f

testing: adding artifact_configs resource to update test

8fac619

testing: set plancheck to ResourceActionDestroyBeforeCreate

23f82e0

rileykarson reviewed Jul 25, 2025

View reviewed changes

testing: skipping acceptance tests

a233f52

github-actions bot requested a review from rileykarson July 25, 2025 18:11

Add terraform support for Developer Connect Insights #14412

Are you sure you want to change the base?

Add terraform support for Developer Connect Insights #14412

Conversation

ishamiGIT commented Jun 30, 2025

Uh oh!

github-actions bot commented Jun 30, 2025

Uh oh!

modular-magician commented Jun 30, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jun 30, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 30, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 7, 2025

Uh oh!

ishamiGIT commented Jul 8, 2025

Uh oh!

melinath commented Jul 9, 2025

Uh oh!

ishamiGIT commented Jul 9, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jul 9, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jul 9, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

modular-magician commented Jul 11, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jul 11, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 11, 2025

Uh oh!

modular-magician commented Jul 14, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jul 14, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jul 24, 2025

Uh oh!

modular-magician commented Jul 24, 2025

Diff report

Missing test report