Note, the added tests required me to enable the enable_reservation_based_fairness config option for my google project (not sure if this is enabled in the CI?).

Otherwise you will run into the following error:

❯ make testacc TEST=./google-beta/services/bigqueryreservation TESTARGS='-run=TestAccBigqueryReservation_withScalingMode_update'

==> Checking that code complies with gofmt requirements...
go vet
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta/services/bigqueryreservation -v -run=TestAccBigqueryReservation_withScalingMode_update -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN   TestAccBigqueryReservation_withScalingMode_update
=== PAUSE TestAccBigqueryReservation_withScalingMode_update
=== CONT  TestAccBigqueryReservation_withScalingMode_update
    resource_bigquery_reservation_test.go:50: Step 1/4 error: Error running apply: exit status 1

        Error: Error creating Reservation: googleapi: Error 400: Cannot use max slots without enabling reservation-based fairness.

          with google_bigquery_reservation.reservation,
          on terraform_plugin_test.tf line 2, in resource "google_bigquery_reservation" "reservation":
           2: resource "google_bigquery_reservation" "reservation" {

--- FAIL: TestAccBigqueryReservation_withScalingMode_update (1.60s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-google-beta/google-beta/services/bigqueryreservation    2.312s
FAIL
make: *** [testacc] Error 1

Test run after enabling enable_reservation_based_fairness:

❯ make testacc TEST=./google-beta/services/bigqueryreservation TESTARGS='-run=TestAccBigqueryReservation_withScalingMode_update'

==> Checking that code complies with gofmt requirements...
go vet
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta/services/bigqueryreservation -v -run=TestAccBigqueryReservation_withScalingMode_update -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN   TestAccBigqueryReservation_withScalingMode_update
=== PAUSE TestAccBigqueryReservation_withScalingMode_update
=== CONT  TestAccBigqueryReservation_withScalingMode_update
--- PASS: TestAccBigqueryReservation_withScalingMode_update (9.21s)
PASS
ok      github.com/hashicorp/terraform-provider-google-beta/google-beta/services/bigqueryreservation    9.938s

And full test run:

❮ make testacc TEST=./google-beta/services/bigqueryreservation TESTARGS='-run=TestAccBigqueryReservation_'

==> Checking that code complies with gofmt requirements...
go vet
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta/services/bigqueryreservation -v -run=TestAccBigqueryReservation_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN   TestAccBigqueryReservation_withDisasterRecovery_update
=== PAUSE TestAccBigqueryReservation_withDisasterRecovery_update
=== RUN   TestAccBigqueryReservation_withScalingMode_update
=== PAUSE TestAccBigqueryReservation_withScalingMode_update
=== CONT  TestAccBigqueryReservation_withDisasterRecovery_update
=== CONT  TestAccBigqueryReservation_withScalingMode_update
--- PASS: TestAccBigqueryReservation_withScalingMode_update (8.95s)
--- PASS: TestAccBigqueryReservation_withDisasterRecovery_update (9.04s)
PASS
ok      github.com/hashicorp/terraform-provider-google-beta/google-beta/services/bigqueryreservation    9.788s

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 72 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 301 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Tests analytics

Total tests: 11
Passed tests: 10
Skipped tests: 0
Affected tests: 1

Get to know how VCR tests work

🔴 Tests failed during RECORDING mode:
TestAccBigqueryReservation_withScalingMode_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Just want to make sure, to enable_reservation_based_fairness, is that a project setting, or a permission setting to a service account?

Just want to make sure, to enable_reservation_based_fairness, is that a project setting, or a permission setting to a service account?

That is a project-level config. The documentation link has more details.

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 72 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 301 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Tests analytics

Total tests: 11
Passed tests: 10
Skipped tests: 0
Affected tests: 1

Get to know how VCR tests work

🔴 Tests failed during RECORDING mode:
TestAccBigqueryReservation_withScalingMode_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Just want to make sure, to enable_reservation_based_fairness, is that a project setting, or a permission setting to a service account?

That is a project-level config. The documentation link has more details.

Any status update on setting this project level config for the CI in the meantime?

Just want to make sure, to enable_reservation_based_fairness, is that a project setting, or a permission setting to a service account?

That is a project-level config. The documentation link has more details.

Any status update on setting this project level config for the CI in the meantime?

I tried to enable it and it's not too straight forward, could someone help for the test setup?

Just want to make sure, to enable_reservation_based_fairness, is that a project setting, or a permission setting to a service account?

That is a project-level config. The documentation link has more details.

Any status update on setting this project level config for the CI in the meantime?

I tried to enable it and it's not too straight forward, could someone help for the test setup?

Could you share more info on what error you saw when trying to enable the setting?

Just want to make sure, to enable_reservation_based_fairness, is that a project setting, or a permission setting to a service account?

That is a project-level config. The documentation link has more details.

Any status update on setting this project level config for the CI in the meantime?

I tried to enable it and it's not too straight forward, could someone help for the test setup?

Could you share more info on what error you saw when trying to enable the setting?

I created a predictable reservation with the ID reservationtest, does that help?

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 7 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 8 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Just want to make sure, to enable_reservation_based_fairness, is that a project setting, or a permission setting to a service account?

That is a project-level config. The documentation link has more details.

Any status update on setting this project level config for the CI in the meantime?

I tried to enable it and it's not too straight forward, could someone help for the test setup?

Could you share more info on what error you saw when trying to enable the setting?

I created a predictable reservation with the ID reservationtest, does that help?

@hao-nan-li To enable the test in this PR to run, we need to set enable_reservation_based_fairness = true in the region of the reservation. Since you were able to create a predictable reservation, you must have already run the ALTER PROJECT ... SET OPTIONS ... statement. Was it in project ci-test-project-188019, and in region us-west2 (specified in this PR). If it was a different region, we can either run the ALTER PROJECT on us-west2 again, or update the test in this PR to use whatever region you already set the option for. Otherwise, we shouldn't need any static reservation to remain in this project for this test, just the project-level setting.

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 9 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.