resourceIdentity: explcit conditional check of empty ID for identity import use
#14309
+52
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 4962 Click here to see the affected service packages
Action takenFound 221 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
@zli82016 the failing tests seem to be unrelated to the import state changes. A sync to the main branch would resolve them as we see that they had been failing during the time of the last sync for the feature branch in teamcity, this failure is specifically seen for |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 4948 Click here to see the affected service packages
Action takenFound 3076 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
@BBBmau, thanks for the information. Can you please sync the main branch to this feature branch to fix the failing test? I am not sure if there are other issues or not with the test failures. Thanks. |
zli82016
reviewed
Jun 25, 2025
zli82016
reviewed
Jun 25, 2025
made the PR to sync the feature branch here: #14374 |
|
@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
|
@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
|
@BBBmau, can you please address the comments in this PR? We can merge this PR with the tgc unit test error, as I don't want this PR is blocked by tgc. |
@BBBmau , do you remember where the |
this comes from the latest terraform-sdk/v2 introducing the new RPC call which is |
In which PRs |
the we'd probably want to introduce this into upstream magic-modules to make the sync easier this is the commit that introduces it in sync that resolves the GetResolve tests: bf9db57#diff-f49170d867cee4233a1f5074c705d38f5fc3e15101320cd02e84d09de6f5a7ddL15-R16 though this leaves us with how to resolve the TGC failing tests present here: https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/16454734810/job/46509029130?pr=14590 |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
zli82016
reviewed
Jul 24, 2025
zli82016
approved these changes
Jul 24, 2025
|
We need to figure out the reason that tgc unit test failed. But I don't want it to block the merging of this PR. Please merge this PR after all of the checks finish. |
Tests analyticsTotal tests: 4948 Click here to see the affected service packages
Action takenFound 3097 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 4950 Click here to see the affected service packages
Action takenFound 3099 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 4943 Click here to see the affected service packages
Action takenFound 3092 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4947 Click here to see the affected service packages
Action takenFound 3096 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 4951 Click here to see the affected service packages
Action takenFound 3100 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves upon:
resourceIdentity: add identity logic inParseImportId#13921as we weren't explicitly checking whether the id was
""or not something that must be done when wanting to useResourceIdentityimport since we do not provide an Id string when utilizing the new identity blockThis fix comes after being able to run in TC CI and detecting test failures, the most recent run is with this fix which was applied on
identity_playgroundbranch which is where the CI is being run on.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.