Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 52 insertions(+), 52 deletions(-))
google-beta provider: Diff ( 2 files changed, 52 insertions(+), 52 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field metadata changed from optional to required on google_vertex_ai_index - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Thanks for the contribution.

Do we know that the API will never accept an empty value for this field?

Also, please replace

```release-note:REPLACEME

```

with

```release-note:breaking-change
vertexai: made the `metadata` field required in `google_vertex_ai_index`
```

in the description

Tests analytics

Total tests: 67
Passed tests: 64
Skipped tests: 3
Affected tests: 0

View the build log

Hi @trodge yes, the API returns a 400 response from the API, stating metadata is missing. When it is omitted, or empty!

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Hi @trodge, just checking in — is there anything else you'd like me to address in this PR before it can be approved? Let me know if any further changes are needed!

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sorry for the delay,

I asked the API team internally about this issue and they indicated that they would prefer to keep the terraform field aligned with the API field in not being required in the specification, even though there is currently no way to create the resource without it. I suggested making a description change in the API spec to indicate that the field is currently required, and we could safely do that here in the mean time.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@trodge any latest update on this to share? This is a HashiCorp support team reported issue. Please advise on best next steps to get this resolved. Thanks!

@trodge any latest update on this to share? This is a HashiCorp support team reported issue. Please advise on best next steps to get this resolved. Thanks!

At this point, I think the next step is to note the issue in the field's description without making it required, which would be a breaking change.