Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field template.containers.ports transitioned from optional+computed to optional google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Tests analytics

Total tests: 49
Passed tests: 23
Skipped tests: 5
Affected tests: 21

Action taken

Get to know how VCR tests work

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2ServiceIamBindingGenerated [Error message] [Debug log]
TestAccCloudRunV2ServiceIamMemberGenerated [Error message] [Debug log]
TestAccCloudRunV2ServiceIamPolicyGenerated [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceBasicExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceDirectvpcExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceGpuExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceHTTPProbesUpdate [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceInvokeriamExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceLimitsExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceMeshExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceMeshUpdate [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceProbesExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSecretExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithDefaultUriDisabled [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithDirectVPCUpdate [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithServiceMinInstances [Error message] [Debug log]
TestAccDataSourceGoogleCloudRunV2Service_basic [Error message] [Debug log]
TestAccDataSourceGoogleCloudRunV2Service_bindIAMPermission [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Hey @trodge 👋 Not sure what's wrong with the tests. Can you please point me in the right direction?

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

It looks like a diff after apply error:

  error=
  | After applying this test step, the plan was not empty.
  | stdout:
  | 
  | 
  | Terraform used the selected providers to generate the following execution
  | plan. Resource actions are indicated with the following symbols:
  |   ~ update in-place
  | 
  | Terraform will perform the following actions:
  | 
  |   # google_cloud_run_v2_service.default will be updated in-place
  |   ~ resource "google_cloud_run_v2_service" "default" {
  |         id                      = "projects/ci-test-project-188019/locations/us-central1/services/tf-test-cloudrun-servicevd8zlws3f9"
  |         name                    = "tf-test-cloudrun-servicevd8zlws3f9"
  |         # (31 unchanged attributes hidden)
  | 
  |       ~ template {
  |           + annotations                      = {}
  |           + labels                           = {}
  |             # (7 unchanged attributes hidden)
  | 
  |           ~ containers {
  |               + args        = []
  |               + command     = []
  |               + depends_on  = []
  |                 name        = null
  |                 # (2 unchanged attributes hidden)
  | 
  |               - ports {
  |                   - container_port = 8080 -> null
  |                   - name           = "http1" -> null
  |                 }
  | 
  |                 # (2 unchanged blocks hidden)
  |             }
  | 
  |             # (1 unchanged block hidden)
  |         }
  | 
  |         # (1 unchanged block hidden)
  |     }
  | 
  | Plan: 0 to add, 1 to change, 0 to destroy.

These are typically caused by a difference between the resource that is sent to the API in a create or update request and the resource that is read from the API GET response.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@trodge Isn't that normal though? Cloud run adds the default port when creating the resource, so having that field returned from the API is expected

@trodge Isn't that normal though? Cloud run adds the default port when creating the resource, so having that field returned from the API is expected

That's the reason we have default_from_api: true for this field.

Hi @trodge
I wrote a failing test, but I can't find a combination of settings that would make the old and the new tests succeed. Can you please point me in the right direction? Should I write a custom flattened, or is there a simpler solution?

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 90 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 90 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field template.containers.ports transitioned from optional+computed to optional google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Tests analytics

Total tests: 52
Passed tests: 23
Skipped tests: 5
Affected tests: 24

Action taken

Get to know how VCR tests work

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceSidecarUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2ServiceIamBindingGenerated [Error message] [Debug log]
TestAccCloudRunV2ServiceIamMemberGenerated [Error message] [Debug log]
TestAccCloudRunV2ServiceIamPolicyGenerated [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceBasicExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceDirectvpcExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample_update [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceGpuExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceHTTPProbesUpdate [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceInvokeriamExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceLimitsExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceMeshExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceMeshUpdate [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceProbesExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSecretExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithDefaultUriDisabled [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithDirectVPCUpdate [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithServiceMinInstances [Error message] [Debug log]
TestAccDataSourceGoogleCloudRunV2Service_basic [Error message] [Debug log]
TestAccDataSourceGoogleCloudRunV2Service_bindIAMPermission [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 7 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 8 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 9 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 11 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 12 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 13 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 14 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 15 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 16 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 17 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

/gcbrun

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 18 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 19 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 20 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 21 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 22 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 23 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 24 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 90 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 90 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field template.containers.ports transitioned from optional+computed to optional google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Tests analytics

Total tests: 82
Passed tests: 47
Skipped tests: 9
Affected tests: 26

Get to know how VCR tests work

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2ServiceIamBindingGenerated [Error message] [Debug log]
TestAccCloudRunV2ServiceIamMemberGenerated [Error message] [Debug log]
TestAccCloudRunV2ServiceIamPolicyGenerated [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceBasicExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceDirectvpcExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample_update [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceGpuExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceHTTPProbesUpdate [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceInvokeriamExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceLimitsExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceMeshExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceMeshUpdate [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceProbesExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSecretExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithDefaultUriDisabled [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithDirectVPCUpdate [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithManualScaling [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceWithServiceMinInstances [Error message] [Debug log]
TestAccDataSourceGoogleCloudRunV2Service_basic [Error message] [Debug log]
TestAccDataSourceGoogleCloudRunV2Service_bindIAMPermission [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 25 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 26 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 27 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 28 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.