Update data_loss_prevention_discovery_config to include field support for OtherCloudDiscoveryTarget #12114

patrickmoy · 2024-10-24T08:49:50Z

Note that OtherCloudDiscoveryTarget currently only supports AWS S3 buckets in this update.

Release Note Template for Downstream PRs (will be copied)

dlp: added `other_cloud_target` and `other_cloud_starting_location` to `google_data_loss_prevention_discovery_config`

github-actions · 2024-10-24T08:50:27Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-10-24T09:01:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
google-beta provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 512 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2024-10-24T09:03:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
google-beta provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 512 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2024-10-24T09:07:19Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2024-10-24T09:08:58Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2024-10-24T09:12:34Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-24T09:23:07Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-24T12:53:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
google-beta provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 512 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2024-10-24T12:58:59Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2024-10-24T13:14:45Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

patrickmoy · 2024-11-08T01:53:12Z

/gcbrun

modular-magician · 2024-11-08T02:05:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
google-beta provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 512 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2024-11-08T02:13:52Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2024-11-08T02:31:16Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

patrickmoy · 2024-11-16T00:13:09Z

/gcbrun

patrickmoy · 2024-11-18T19:23:21Z

/gcbrun

patrickmoy · 2024-11-19T03:42:07Z

/gcbrun

patrickmoy · 2024-11-19T08:04:04Z

/gcbrun

SirGitsalot

One nit and a suggestion for a config addition, but otherwise LGTM!

SirGitsalot · 2024-11-20T23:55:15Z

mmv1/products/dlp/DiscoveryConfig.yaml

+      - name: 'awsLocation'
+        type: NestedObject
+        properties:
+          - name: 'accountId'


According to the docs it's possible to specify accountId or allAssetInventoryAssets, but not both. I'm not sure if leaving both unset is valid, but in either case you can improve the user experience by adding either:

conflicts to both fields, if they're allowed to be unset

exactly_one_of if one of them is required to be set

Conflict added.

SirGitsalot · 2024-11-20T23:59:30Z

...terraform/services/datalossprevention/resource_data_loss_prevention_discovery_config_test.go

+}
+resource "google_organization_iam_member" "dlp_role" {
+    org_id = "%{organization}"
+	role    = "roles/dlp.orgdriver"


nit: there's some weird indentation in the test configs (GitHub doesn't show it, but I'll bet it's due to a combination of tabs and spaces)

github-actions · 2025-05-02T09:43:27Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

patrickmoy · 2025-05-05T18:55:38Z

@SirGitsalot sorry for the delay in putting in the requested changes, but can you take another look?

github-actions · 2025-05-09T09:43:50Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2025-05-15T23:43:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2208 insertions(+), 615 deletions(-))
google-beta provider: Diff ( 4 files changed, 2208 insertions(+), 615 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 501 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2025-05-15T23:49:37Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2025-05-16T00:08:07Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

SirGitsalot

Sorry for the delay! I think I got so used to seeing this PR in my list that I became blind to it ☹️

The debug link for the failing test log isn't working for me, but I checked it directly and it's failing with an invalid argument:

---[ REQUEST ]---------------------------------------
POST /v2/organizations/529579013760/locations/us-central1/discoveryConfigs?alt=json HTTP/1.1
Host: dlp.googleapis.com
User-Agent: Terraform/1.11.0 (+https://www.terraform.io) Terraform-Plugin-SDK/2.36.0 terraform-provider-google-beta/acc
Content-Length: 588
Content-Type: application/json
Accept-Encoding: gzip

{
 "discoveryConfig": {
  "inspectTemplates": [
   "projects/ci-test-project-188019/inspectTemplates/7702440615858682251"
  ],
  "orgConfig": {
   "location": {
    "organizationId": "529579013760"
   },
   "projectId": "ci-test-project-188019"
  },
  "otherCloudStartingLocation": {
   "awsLocation": {
    "accountId": "012345678910"
   }
  },
  "status": "RUNNING",
  "targets": [
   {
    "otherCloudTarget": {
     "dataSourceType": {
      "dataSource": "aws/s3/bucket"
     },
     "disabled": null,
     "filter": {
      "others": {}
     },
     "generationCadence": {
      "inspectTemplateModifiedCadence": {
       "frequency": "UPDATE_FREQUENCY_MONTHLY"
      },
      "refreshFrequency": "UPDATE_FREQUENCY_MONTHLY"
     }
    },
    "secretsTarget": null
   }
  ]
 }
}

-----------------------------------------------------
2025/05/16 00:06:33 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 400 Bad Request
Content-Type: application/json; charset=UTF-8
Date: Fri, 16 May 2025 00:06:33 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "error": {
    "code": 400,
    "message": "Duplicated discovery config of type AWS S3 buckets is not allowed. There is already another config with the same data profile location (Organization ID: 529579013760, AWS Account ID: 012345678910).",
    "status": "INVALID_ARGUMENT",
    "details": [
      {
        "@type": "type.googleapis.com/google.rpc.ErrorInfo",
        "reason": "3",
        "domain": "dlp.googleapis.com"
      }
    ]
  }
}

Is 012345678910 a special testing constant, or can we randomize that?

patrickmoy · 2025-05-19T22:05:02Z

Sorry for the delay! I think I got so used to seeing this PR in my list that I became blind to it ☹️

The debug link for the failing test log isn't working for me, but I checked it directly and it's failing with an invalid argument:

---[ REQUEST ]---------------------------------------
POST /v2/organizations/529579013760/locations/us-central1/discoveryConfigs?alt=json HTTP/1.1
Host: dlp.googleapis.com
User-Agent: Terraform/1.11.0 (+https://www.terraform.io) Terraform-Plugin-SDK/2.36.0 terraform-provider-google-beta/acc
Content-Length: 588
Content-Type: application/json
Accept-Encoding: gzip

{
 "discoveryConfig": {
  "inspectTemplates": [
   "projects/ci-test-project-188019/inspectTemplates/7702440615858682251"
  ],
  "orgConfig": {
   "location": {
    "organizationId": "529579013760"
   },
   "projectId": "ci-test-project-188019"
  },
  "otherCloudStartingLocation": {
   "awsLocation": {
    "accountId": "012345678910"
   }
  },
  "status": "RUNNING",
  "targets": [
   {
    "otherCloudTarget": {
     "dataSourceType": {
      "dataSource": "aws/s3/bucket"
     },
     "disabled": null,
     "filter": {
      "others": {}
     },
     "generationCadence": {
      "inspectTemplateModifiedCadence": {
       "frequency": "UPDATE_FREQUENCY_MONTHLY"
      },
      "refreshFrequency": "UPDATE_FREQUENCY_MONTHLY"
     }
    },
    "secretsTarget": null
   }
  ]
 }
}

-----------------------------------------------------
2025/05/16 00:06:33 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 400 Bad Request
Content-Type: application/json; charset=UTF-8
Date: Fri, 16 May 2025 00:06:33 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "error": {
    "code": 400,
    "message": "Duplicated discovery config of type AWS S3 buckets is not allowed. There is already another config with the same data profile location (Organization ID: 529579013760, AWS Account ID: 012345678910).",
    "status": "INVALID_ARGUMENT",
    "details": [
      {
        "@type": "type.googleapis.com/google.rpc.ErrorInfo",
        "reason": "3",
        "domain": "dlp.googleapis.com"
      }
    ]
  }
}

Is 012345678910 a special testing constant, or can we randomize that?

Hmmm, we could randomize it, but the bigger issue here is that the custom sweeper I wrote some time ago doesn't seem to be picking this up and deleting the config... we have an API limit on number of configs per profiling type, and the sweeper is supposed to delete these in case tests fail so we don't block subsequent runs.

patrickmoy · 2025-05-19T22:06:40Z

What I can do is run a backfill to delete the offending config on our end to unblock this PR (we just added support for this kind of troubleshooting action), but I'll have to take another look at the sweeper to see why it's not cleaning this up.

patrickmoy · 2025-05-19T22:48:06Z

I'll let you know when the backfiller is complete so we can rerun this test.

patrickmoy · 2025-05-20T07:00:49Z

@SirGitsalot The config has been removed; can re-run and see if it passes.

patrickmoy · 2025-05-20T07:00:55Z

/gcbrun

github-actions · 2025-05-22T09:44:15Z

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-05-26T09:54:41Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-06-02T09:44:30Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2025-06-03T22:35:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2208 insertions(+), 615 deletions(-))
google-beta provider: Diff ( 4 files changed, 2208 insertions(+), 615 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 501 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2025-06-03T22:41:57Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2025-06-03T23:04:45Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

SirGitsalot · 2025-06-04T00:03:29Z

...terraform/services/datalossprevention/resource_data_loss_prevention_discovery_config_test.go

+	return acctest.Nprintf(`
+data "google_project" "project" {
+}
+resource "google_organization_iam_member" "org_admin" {


I re-ran the test it's failing on these two google_organization_iam_member resources. The service account that the tests run as doesn't have the org admin role to avoid an errant test nuking access to the whole org. Instead, when an org-level IAM role is needed we add it to main.tf as you did above (although that's really just for documentation purposes and the actual change is made manually, which I'll do once I confirm what's needed).

If the service account running the test has the roles/dlp.admin role and the DLP project-level service account has the roles/dlp.orgDriver on the test organization, will that be sufficient? If so, I'll make the change for the former, and I believe that the latter will use a bootstrapped IAM resource.

That should be sufficient, yes. roles/dlp.orgDriver was intended to cover the permissions needed.

I've added roles/dlp.admin to the test runner service account, you'll need to add the bootstrap role a la:

bootstrap_iam: - member: "serviceAccount:service-{project_number}@dlp-api.iam.gserviceaccount.com" role: "roles/dlp.orgDriver"

github-actions · 2025-06-18T09:44:36Z

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

SirGitsalot · 2025-06-18T23:40:13Z

...terraform/services/datalossprevention/resource_data_loss_prevention_discovery_config_test.go

+	return acctest.Nprintf(`
+data "google_project" "project" {
+}
+resource "google_organization_iam_member" "org_admin" {


I've added roles/dlp.admin to the test runner service account, you'll need to add the bootstrap role a la:

bootstrap_iam: - member: "serviceAccount:service-{project_number}@dlp-api.iam.gserviceaccount.com" role: "roles/dlp.orgDriver"

github-actions · 2025-07-02T09:45:31Z

@patrickmoy, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

…veryTarget, which currently only supports AWS S3 buckets.

github-actions · 2025-07-14T09:47:06Z

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-07-16T09:46:06Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-07-23T09:47:14Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions bot requested a review from SirGitsalot October 24, 2024 08:50

patrickmoy force-pushed the main branch from 57e7ab6 to 783d8ed Compare October 24, 2024 08:52

modular-magician added the service/dlp label Oct 24, 2024

modular-magician requested a review from catherinerosesantos October 24, 2024 09:01

patrickmoy force-pushed the main branch from 783d8ed to 64c7cd1 Compare October 24, 2024 12:41

patrickmoy marked this pull request as draft October 24, 2024 18:59

patrickmoy force-pushed the main branch from 64c7cd1 to 35a39f7 Compare November 18, 2024 18:48

patrickmoy marked this pull request as ready for review November 19, 2024 08:02

patrickmoy force-pushed the main branch from 6863948 to 917c1a5 Compare November 19, 2024 08:40

patrickmoy marked this pull request as draft November 19, 2024 18:59

patrickmoy marked this pull request as ready for review November 19, 2024 20:25

SirGitsalot reviewed Nov 21, 2024

View reviewed changes

SirGitsalot reviewed May 16, 2025

View reviewed changes

github-actions bot requested a review from SirGitsalot May 19, 2025 22:05

SirGitsalot reviewed Jun 4, 2025

View reviewed changes

patrickmoy requested a review from SirGitsalot June 13, 2025 20:56

SirGitsalot requested changes Jun 18, 2025

View reviewed changes

Add data_loss_prevention_discovery_config support for OtherCloudDisco…

49b4941

…veryTarget, which currently only supports AWS S3 buckets.

patrickmoy force-pushed the main branch from 75a8eb3 to 49b4941 Compare July 9, 2025 09:42

github-actions bot requested a review from SirGitsalot July 9, 2025 09:43

Update data_loss_prevention_discovery_config to include field support for OtherCloudDiscoveryTarget #12114

Are you sure you want to change the base?

Update data_loss_prevention_discovery_config to include field support for OtherCloudDiscoveryTarget #12114

Uh oh!

Conversation

patrickmoy commented Oct 24, 2024

Uh oh!

github-actions bot commented Oct 24, 2024

Uh oh!

modular-magician commented Oct 24, 2024

Diff report

Missing test report

Uh oh!

modular-magician commented Oct 24, 2024

Diff report

Missing test report

Uh oh!

modular-magician commented Oct 24, 2024

Tests analytics

Action taken

Uh oh!

modular-magician commented Oct 24, 2024

Tests analytics

Action taken

Uh oh!

modular-magician commented Oct 24, 2024

Uh oh!

modular-magician commented Oct 24, 2024

Uh oh!

modular-magician commented Oct 24, 2024

Diff report

Missing test report

Uh oh!

modular-magician commented Oct 24, 2024

Tests analytics

Action taken

Uh oh!

modular-magician commented Oct 24, 2024

Uh oh!

patrickmoy commented Nov 8, 2024

Uh oh!

modular-magician commented Nov 8, 2024

Diff report

Missing test report

Uh oh!

modular-magician commented Nov 8, 2024

Tests analytics

Action taken

Uh oh!

modular-magician commented Nov 8, 2024

Uh oh!

patrickmoy commented Nov 16, 2024

Uh oh!

patrickmoy commented Nov 18, 2024

Uh oh!

patrickmoy commented Nov 19, 2024

Uh oh!

patrickmoy commented Nov 19, 2024

Uh oh!

SirGitsalot left a comment

Choose a reason for hiding this comment

Uh oh!

SirGitsalot Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

patrickmoy Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

SirGitsalot Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 2, 2025

Uh oh!

patrickmoy commented May 5, 2025

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

modular-magician commented May 15, 2025

Diff report

Missing test report

patrickmoy commented May 19, 2025 •

edited

Loading