feat(mcp): add argument serialization for JSON compatibility #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tommy Nguyen <tuannvm@hotmail.com>
|
@tuannvm This PR https://github.com/GoogleCloudPlatform/kubectl-ai/pull/366/files now relays the input schema exposed by the MCP server properly, I suspect, it will eliminate the need for this PR. |
|
See this one as well https://github.com/GoogleCloudPlatform/kubectl-ai/pull/369/files, its related as well. Overall, we should have less logic between LLM and MCP exchange. |
I'm not sure it eliminates the need for this PR, I can imagine for some LLMs we might need to convert types? But we should do it based on the target schema I think. But maybe the latest LLMs are actually good enough that they just get the schemas right? Would love your thoughts @tuannvm ... |
|
@droot Gotcha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This update refactors the
SerializeArgsForMCPfunction to improve argument serialization for MCP servers. It now recursively handles nested structures such as maps and slices, and converts complex types using JSON marshaling and unmarshaling, ensuring all arguments are in proper JSON-compatible formats before transmission.Affected Modules
pkg/mcp/utils.go: serialization utility functions.pkg/mcp/http_client.go,pkg/mcp/stdio_client.go: argument preparation during tool calls.Key Details
map[string]anyand[]any.SerializeArgsForMCP: now performs deep serialization and type normalization.serializeValue: new recursive helper function, converting values to JSON-compatible representations.