-
Notifications
You must be signed in to change notification settings - Fork 567
feat: Add K8s-bench presubmit workflow for task evaluation #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prasad89
wants to merge
2
commits into
GoogleCloudPlatform:main
Choose a base branch
from
prasad89:presubmit-evals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
name: K8s-bench Presubmit | ||
|
||
on: | ||
pull_request: | ||
paths: | ||
- "k8s-bench/tasks/**" | ||
|
||
jobs: | ||
detect-changed-tasks: | ||
runs-on: ubuntu-latest | ||
outputs: | ||
task_dirs: ${{ steps.get_tasks.outputs.dirs }} | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Detect changed task directories | ||
id: get_tasks | ||
run: | | ||
echo "Fetching base branch..." | ||
git fetch origin ${{ github.base_ref }} --depth=1 | ||
|
||
echo "Finding changed task folders under k8s-bench/tasks..." | ||
CHANGED_DIRS=$(git diff --name-only origin/${{ github.base_ref }} HEAD -- k8s-bench/tasks/ \ | ||
| awk -F/ 'NF>=3 {print $3}' \ | ||
| sort -u) | ||
|
||
echo "Changed folders:" | ||
echo "$CHANGED_DIRS" | ||
|
||
# Output as comma-separated string | ||
echo "dirs=$(echo "$CHANGED_DIRS" | paste -sd ',' -)" >> $GITHUB_OUTPUT | ||
|
||
run-evals: | ||
needs: detect-changed-tasks | ||
if: needs.detect-changed-tasks.outputs.task_dirs != '' | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 30 | ||
permissions: | ||
contents: "read" | ||
id-token: "write" | ||
|
||
strategy: | ||
matrix: | ||
task: ${{ fromJson('["' + needs.detect-changed-tasks.outputs.task_dirs + '"]') }} | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Kind Cluster Setup | ||
uses: ./.github/actions/kind-cluster-setup | ||
with: | ||
cluster_name: ${{ github.head_ref || github.ref_name }} | ||
|
||
- name: Run evals for task ${{ matrix.task }} | ||
env: | ||
TEST_ARGS: >- | ||
--llm-provider vertexai | ||
--models gemini-2.5-pro-preview-05-06 | ||
--enable-tool-use-shim=false | ||
--task-pattern=${{ matrix.task }} | ||
run: | | ||
echo "Running eval for ${{ matrix.task }}" | ||
./dev/ci/periodics/run-evals.sh | ||
|
||
- name: Analyze results | ||
run: | | ||
./dev/ci/periodics/analyze-evals.sh | ||
cat ${{ github.workspace }}/.build/k8s-bench.md >> $GITHUB_STEP_SUMMARY |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible here to run on multiple envs, like ubuntu and windows? Not sure that this is something we want now, I'm just curious if possible and what it would look like.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's possible to support multiple environments, such as Linux, Windows, and macOS.
However, my understanding is that the goal here is to run the modified task as a presubmit job.
This setup is also capable of running multiple jobs, depending on what has been modified.
@droot can confirm