这是indexloc提供的服务,不要输入任何密码
Skip to content

Add Krew release automation #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LefterisXefteris
Copy link

No description provided.

Copy link

google-cla bot commented May 14, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@droot
Copy link
Member

droot commented May 14, 2025

Thanks for the PR. I have one question about the dependency on our release workflow.

We are using goreleaser to publish releases on very new tag and I am assuming release needs to be published before we publish the krew manifest. I also remember seeing goreleaser itself providing a mechanism to integrate krew automation ( I will have to look into it).

@droot
Copy link
Member

droot commented May 19, 2025

@LefterisXefteris gentle reminder about the question above :)

@LefterisXefteris
Copy link
Author

Hi @droot,
Thanks for the reminder! To confirm: would you prefer that we drop the standalone krew-release-bot step and instead rely on GoReleaser’s built-in krews publisher to automatically open the PR against kubernetes-sigs/krew-index after tagging?

Please let me know if that approach works—or if you’d rather keep the existing bot step. Thanks!

@droot
Copy link
Member

droot commented May 21, 2025

@LefterisXefteris

Lets add the krew-release-bot step in the existing release workflow as shown in the example here https://github.com/rajatjindal/krew-release-bot?tab=readme-ov-file#example-when-using-go-releaser (ofc use the action image that you have).

This will ensure that the pull request for krew-index is created after we have published the release and will also consolidate all the release steps in one workflow.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants