这是indexloc提供的服务，不要输入任何密码
Skip to content

Refactor the API to move NodeConfig, Patch to Extensions. (Breaking Change) #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2018
Merged

Refactor the API to move NodeConfig, Patch to Extensions. (Breaking Change) #49

merged 3 commits into from
Oct 16, 2018

Conversation

@artasparks
Copy link
Contributor

@artasparks artasparks commented Oct 16, 2018 •
edited
Loading

This will hopefully be the last of the mega API refactors, and even this one is a bit smaller than previous.

  • Add a Spec to ComponentPackage. This allows us flexibility later if we decide we want a status field.
  • Move NodeConfig to be a Bundle Extension rather than a core part of the Bundle. Now everything's just components!
  • Re-add the Patch (as PatchTemplate) to Bundle Extensions. It's not currently used, but it's a good example of something that could be a bundle extenison.

Addresses: #46
Fixes: #45
Fixes: #42

@artasparks artasparks requested a review from jplobosgle October 16, 2018 16:37
@artasparks artasparks changed the title Refactor the API to. (Breaking Change) Refactor the API to remove NodeConfig. (Breaking Change) Oct 16, 2018
@artasparks artasparks changed the title Refactor the API to remove NodeConfig. (Breaking Change) Refactor the API to move NodeConfig, Patch to Extensions. (Breaking Change) Oct 16, 2018
@jplobosgle
Copy link
Contributor

jplobosgle commented Oct 16, 2018

LGTM

@artasparks artasparks merged commit 6d6863d into GoogleCloudPlatform:master Oct 16, 2018
@artasparks artasparks deleted the api3 branch April 7, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jplobosgle jplobosgle Awaiting requested review from jplobosgle

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artasparks @jplobosgle