Remove the build-id for debugging #321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resources/td-agent/rpm/rpmmacros.erb
Outdated
| %_signature gpg | ||
| %_gpg_path <%= gpg_path %> | ||
| %_gpg_name <%= gpg_name %> | ||
| %define debug_package %{nil} |
There was a problem hiding this comment.
Your initial commit (with %define _build_id_links none) should have been sufficient… Any reason it didn't work?
Author
|
I'm having trouble with testing this PR and with the many versions. I started a new PR that has the ulitmate fix and is cleaner: #328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CentOS 8, there is a new feature to add a unique build ID into binaries for debugging.
Because we pull in the same protobuf shared libraries as the gitlab-ce package, this causes a conflict on CentOS 8, where a user cannot install both google-fluentd and gitlab-ce on the same system.
To preproduce:
This will cause errors that look like this:
In order to fix this, we will turn off build_id generation for google-fluent by adding
%define _build_id_links noneto a newresources/td-agent/rpm/rpmmacros.erbfile in our repo to turn off this feature, as per Omnibus docs: https://github.com/chef/omnibus/blob/master/docs/Building%20on%20RHEL.md).