Clarify that the API request size limit is 10MB, not 5MB. #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f481ae to
089ef53
Compare
igorpeshansky
suggested changes
Jan 15, 2021
templates/etc/td-agent/td-agent.conf
Outdated
| # Set the chunk limit conservatively to avoid exceeding the recommended | ||
| # chunk size of 5MB per write request. | ||
| # chunk size of 10MB per write request. The API request size can be a few | ||
| # times biggers than the raw log size. |
| # Set the chunk limit conservatively to avoid exceeding the recommended | ||
| # chunk size of 5MB per write request. | ||
| # chunk size of 10MB per write request. The API request size can be a few | ||
| # times biggers than the raw log size. |
qingling128
commented
Jan 15, 2021
Author
qingling128
left a comment
There was a problem hiding this comment.
Nice catch! Fixed the typo.
igorpeshansky
suggested changes
Jan 29, 2021
igorpeshansky
left a comment
There was a problem hiding this comment.
One more place for this change.
| buffer_type file | ||
| buffer_path /var/log/google-fluentd/buffers | ||
| # Set the chunk limit conservatively to avoid exceeding the recommended | ||
| # chunk size of 5MB per write request. |
There was a problem hiding this comment.
Do we need the same change in windows-installer/fluent-template.conf?
0512b52 to
1bd2c02
Compare
qingling128
commented
Apr 28, 2021
| buffer_type file | ||
| buffer_path /var/log/google-fluentd/buffers | ||
| # Set the chunk limit conservatively to avoid exceeding the recommended | ||
| # chunk size of 5MB per write request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.