这是indexloc提供的服务，不要输入任何密码
Skip to content

test(rapid appends): appends from a handle after takeover from another client must fail #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 24, 2025
Merged

test(rapid appends): appends from a handle after takeover from another client must fail #3522

merged 15 commits into from
Jul 24, 2025
+47 −5

Conversation

anushka567
Copy link
Member

@anushka567 anushka567 commented Jul 15, 2025 •
edited
Loading

Description

This PR introduces a new functional test, TestAppendSessionInvalidatedByAnotherClientUponTakeover, to verify the correct handling of concurrent append operations on the same unfinalized object from different GCSfuse mount

The sequence of operations is as follows:

  • An append session is initiated on a file from a primary mount.
  • A second mount (new client to initiate takeover) opens a new file handle to the same file for appending. This action successfully takes over the append session.
  • The test asserts that subsequent append attempts from the original file handle now fail with NFS Stale File Handle error, as its session has been invalidated by the takeover .
  • It also confirms that the new file handle from the second mount can continue to write and sync successfully.

Link to the issue in case of a bug fix.

b/431894122

Testing details

  1. Manual - Manually tested
--- PASS: TestUnfinalizedAppendsSuite (13.94s)
    --- PASS: TestUnfinalizedAppendsSuite/TestAppendSessionInvalidatedByAnotherClientUponTakeover (2.94s)
    --- PASS: TestUnfinalizedAppendsSuite/TestAppendsFromDifferentMount (5.48s)
    --- PASS: TestUnfinalizedAppendsSuite/TestAppendsFromSameMount (4.23s)
  1. Unit tests - NA
  2. Integration tests - NA

Any backward incompatible change? If so, please explain.

@anushka567 anushka567 changed the title feat(ZB integration testing ): appends from a handle after takeover must fail feat(ZB integration testing ): appends from a handle after takeover from another client must fail Jul 15, 2025
@anushka567 anushka567 added the execute-integration-tests-on-zb To run E2E tests on zonal bucket. label Jul 15, 2025
@meet2mky meet2mky force-pushed the meet2mky/append_files_functional_tests branch from 1abac90 to bd5420a Compare July 15, 2025 10:15
@anushka567 anushka567 changed the title feat(ZB integration testing ): appends from a handle after takeover from another client must fail test(zonal bucket ): appends from a handle after takeover from another client must fail Jul 15, 2025
@meet2mky meet2mky force-pushed the meet2mky/append_files_functional_tests branch from 753eee6 to fc5ba01 Compare July 16, 2025 09:46
@anushka567 anushka567 changed the title test(zonal bucket ): appends from a handle after takeover from another client must fail test(rapid appends): appends from a handle after takeover from another client must fail Jul 17, 2025
Base automatically changed from meet2mky/append_files_functional_tests to master July 18, 2025 10:57
@anushka567 anushka567 marked this pull request as ready for review July 22, 2025 03:37
@anushka567 anushka567 requested review from Tulsishah and a team as code owners July 22, 2025 03:37
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Jul 22, 2025
@kislaykishore kislaykishore requested a review from a team July 22, 2025 03:37
vadlakondaswetha
vadlakondaswetha reviewed Jul 22, 2025
View reviewed changes
@anushka567 anushka567 force-pushed the ft-appends-must-fail-when-another-append-in-progress branch 2 times, most recently from 4c28350 to f26c312 Compare July 23, 2025 05:00
@anushka567 anushka567 force-pushed the ft-appends-must-fail-when-another-append-in-progress branch from f26c312 to 4cf2d1e Compare July 23, 2025 05:03
vadlakondaswetha
vadlakondaswetha reviewed Jul 23, 2025
View reviewed changes
anushka567
anushka567 commented Jul 23, 2025
View reviewed changes
@anushka567 anushka567 enabled auto-merge (squash) July 23, 2025 06:52
@anushka567 anushka567 merged commit 97ece1c into master Jul 24, 2025
12 checks passed
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d79e0af) to head (aaf282e).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #3522       +/-   ##
==========================================
- Coverage   79.69%       0   -79.70%     
==========================================
  Files         142       0      -142     
  Lines       18971       0    -18971     
==========================================
- Hits        15119       0    -15119     
+ Misses       3340       0     -3340     
+ Partials      512       0      -512
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadlakondaswetha vadlakondaswetha vadlakondaswetha approved these changes

@Tulsishah Tulsishah Awaiting requested review from Tulsishah Tulsishah is a code owner

Assignees
No one assigned
Labels
execute-integration-tests-on-zb To run E2E tests on zonal bucket. remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anushka567 @vadlakondaswetha @meet2mky @gargnitingoogle