build(sdk): update storage SDK to latest [WIP] #3548
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @meet2mky, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a comprehensive update of the project's Go module dependencies. The main objective is to bring the Google Cloud Storage (GCS) SDK to its latest development version, which necessitates a cascade of updates across other related Google Cloud Go modules, OpenTelemetry libraries, and various golang.org/x packages. This ensures the project is aligned with the most recent dependency versions, paving the way for future GCS SDK releases.
Highlights
- Core SDK Update: The primary change involves updating the
cloud.google.com/go/storageSDK fromv1.55.0to a pre-release versionv1.55.1-0.20250717211807-310da0fabf15. This is in preparation for the upcomingstorage/v1.56.0release. - Google Cloud Go Modules Updates: Several other Google Cloud Go SDKs have been updated, including
cloud.google.com/go/auth(tov0.16.3),cloud.google.com/go/secretmanager(tov1.15.0),google.golang.org/api(tov0.242.0), andgoogle.golang.org/grpc(tov1.73.0), along with variousgoogle.golang.org/genprotopackages. - OpenTelemetry and Standard Library Updates: Numerous OpenTelemetry-related dependencies (e.g.,
go.opentelemetry.io/otel,go.opentelemetry.io/contrib/detectors/gcp) and core Go standard library extensions (golang.org/x/net,golang.org/x/sync,golang.org/x/sys,golang.org/x/text,golang.org/x/time,golang.org/x/crypto) have been bumped to their latest versions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, most notably cloud.google.com/go/storage to a pre-release version. Such changes can introduce unexpected behavior or breaking changes.
The pull request description states that no unit or integration tests were run. It is critical to run the full test suite to ensure that these dependency updates do not break existing functionality. Please run all tests and confirm they pass before this PR is considered for merging.
| cloud.google.com/go/storage v1.55.0 | ||
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.52.0 | ||
| cloud.google.com/go/secretmanager v1.15.0 | ||
| cloud.google.com/go/storage v1.55.1-0.20250717211807-310da0fabf15 |
There was a problem hiding this comment.
Using a pseudo-version for cloud.google.com/go/storage pins the dependency to a specific commit that is not a stable release. This can introduce instability and make dependency management difficult for consumers of this project.
While this might be acceptable for a Work-In-Progress PR, please ensure this is updated to a stable, tagged release (e.g., v1.56.0) before this PR is merged.
cd193b6 to
37952dd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3548 +/- ##
==========================================
+ Coverage 79.74% 79.78% +0.04%
==========================================
Files 141 141
Lines 18931 18931
==========================================
+ Hits 15096 15105 +9
+ Misses 3325 3318 -7
+ Partials 510 508 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updates the GCS SDK to HEAD of main in preparation for the release of storage/v1.56.0
Please ensure your PR title follows the format:
Example:
feat(api): add user login endpoint
Description
Link to the issue in case of a bug fix.
Testing details
Any backward incompatible change? If so, please explain.