这是indexloc提供的服务,不要输入任何密码
Skip to content

test(rapid appends): first write from r+ file handle from amongst concurrent file handles will lead to fallback #3547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: ft-random-writes-in-r+-not-real-time
Choose a base branch
from

Conversation

anushka567
Copy link
Member

@anushka567 anushka567 commented Jul 18, 2025

Description

The functional test covered in this PR covers the fall back scenario in concurrent file handles case when there are multiple file handles opened against the same file inode corresponding to the unfinalized object.
The test includes:

  • open multiple file handles for the same file inode (append mode and read plus mode)
  • First write issued from the read plus mode , will lead to fallback , thus continuing on legacy path.
  • Appends made via this file handle will not be visible in real time.

Link to the issue in case of a bug fix.

b/432667550

Testing details

  1. Manual - Yes. Fallback happens as intended. Waiting on CreateObject() support to validate further.
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @anushka567, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new integration test case to validate specific behavior related to concurrent file operations on unfinalized objects. The test focuses on ensuring that the system correctly handles scenarios where a read-write file handle performs the first write, leading to an expected fallback mechanism.

Highlights

  • New Integration Test: Added a new integration test, TestFallbackHappensWhenRPlusHandleDoesFirstWrite, to unfinalized_appends_test.go. This test is designed to verify the system's fallback behavior when the initial write to an unfinalized object, accessed concurrently by multiple file handles, originates from an r+ (read-write) file handle.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new integration test, TestFallbackHappensWhenRPlusHandleDoesFirstWrite, to verify a fallback mechanism for rapid appends. The test attempts to append data but uses a write operation that overwrites the file from the beginning. I've included a suggestion to correct this.

@anushka567 anushka567 force-pushed the ft-random-writes-in-r+-not-real-time branch from 11d5cf0 to 55f880c Compare July 22, 2025 08:42
@anushka567 anushka567 force-pushed the ft-concurrent-file-handles-fallback-scenario branch from 542a628 to aee29d2 Compare July 22, 2025 08:57
@anushka567 anushka567 marked this pull request as ready for review July 22, 2025 09:05
@anushka567 anushka567 requested review from Tulsishah and a team as code owners July 22, 2025 09:05
@anushka567 anushka567 force-pushed the ft-random-writes-in-r+-not-real-time branch from 55f880c to b4a530d Compare July 23, 2025 08:52
@anushka567 anushka567 force-pushed the ft-concurrent-file-handles-fallback-scenario branch from aee29d2 to ae04636 Compare July 23, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant