minor updates #2189
minor updates #2189
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @erwinh85, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on updating a Gemini tuning notebook to reflect the availability of a newer model version and to properly attribute the author. It also includes minor formatting improvements to the notebook file.
Highlights
- Model Version Update: The
sft_gemini_summarization.ipynbnotebook has been updated to reference the newergemini-2.5-flashmodel, replacing the previously mentionedgemini-2.0-flash-001. - Author Attribution: The author, Erwin Huizenga, has been explicitly added to the list of contributors within the
sft_gemini_summarization.ipynbnotebook. - Notebook Metadata and Formatting: Minor adjustments were made to the notebook's metadata, specifically reordering
toc_visibleandprovenancefields, and ensuring the file ends with a newline character for consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds an author and updates the model name in the sft_gemini_summarization.ipynb notebook.
I have one main concern regarding the model name update, which seems to be applied only to the documentation part of the notebook, potentially creating an inconsistency with the code.
Also, for future contributions, please use a more descriptive PR title that adheres to the Conventional Commits specification, as indicated in the PR template. For example: docs(tuning): Update model name in summarization notebook.
| @@ -761,7 +762,7 @@ | |||
| "source": [ | |||
| "The following Gemini text model support supervised tuning:\n", | |||
| "\n", | |||
| "* `gemini-2.0-flash-001`" | |||
| "* `gemini-2.5-flash`" | |||
There was a problem hiding this comment.
You've updated the model name to gemini-2.5-flash in this markdown cell. While this is a good update, it's crucial to ensure consistency with the code. This notebook likely has a code cell that defines the model to be used (e.g., base_model = "gemini-2.0-flash-001"). Please verify that the model name is also updated in the corresponding code cell(s). A mismatch between the documentation and the code can be misleading for users running the notebook.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.CODEOWNERSfor the file(s).nox -s formatfrom the repository root to format).Fixes #<issue_number_goes_here> 🦕