这是indexloc提供的服务，不要输入任何密码
Skip to content

Slurm image build instruction #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Slurm image build instruction #4698

wants to merge 17 commits into from

Conversation

@ACW101
Copy link
Collaborator

@ACW101 ACW101 commented Sep 25, 2025 •
edited
Loading

As followup to #4607, add instruction to build slurm image for GKE, which is based on SlinkyProject/containers.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

ACW101 added 16 commits September 23, 2025 21:33
@ACW101
Add slurm-gke blueprint
fafa1bf
@ACW101
Attach slurm key as NFS via filestore CSI
9d70465
@ACW101
Remove slinky image reference
cd06ce1
@ACW101
Address comments
9503f55
@ACW101
Change to use public slinky image and some more small fixes
c1d81e6
@ACW101
Small fix after rebase
5130bd3
@ACW101
Removed unused variables for machine types not supported yet in the f…
16ccae4 
…irst vesrion.
@ACW101
Add a new attribute "gke-nodepool" to nodeset config and use it for d…
c1944ee 
…etermining if a node/nodeset is a GKE in controller.
@ACW101
Create PV and PVC from network storage passed into gke nodeset
e83195d
@ACW101
Update gke-nodeset to accept list of network_storage.
7f742e3
@ACW101
Add slurm-gke integration test.
6872248
@ACW101
Fix bug causing slurmsync failed determine GKE nodes
88dfddf
@ACW101
Removed irrelevant instruction output from slinky.
ce74360
@ACW101
Import https://github.com/SlinkyProject/containers/tree/main
3031050
@ACW101
Modify slinky containers dockerfile based on GKE requirements.
fc1fe3d
@ACW101
Update Readme.md and Makefile.
9c4bdb5
@ACW101 ACW101 requested review from a team and samskillman as code owners September 25, 2025 23:25
@ACW101 ACW101 changed the title Slinky image build instruction Slurm image build instruction Sep 25, 2025
@ACW101 ACW101 marked this pull request as draft September 25, 2025 23:26
@ACW101 ACW101 changed the base branch from main to develop September 25, 2025 23:26
@ACW101 ACW101 self-assigned this Sep 26, 2025
@ACW101 ACW101 marked this pull request as ready for review September 26, 2025 06:00
@ACW101 ACW101 requested a review from nick-stroud September 26, 2025 06:00
pawloch00
pawloch00 reviewed Sep 26, 2025
View reviewed changes
@ACW101 ACW101 added the release-improvements Added to release notes under the "Improvements" heading. label Sep 26, 2025
@nick-stroud
Copy link
Collaborator

nick-stroud commented Oct 6, 2025

I am going to wait until #4607 is merged to review this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawloch00 pawloch00 pawloch00 left review comments

@samskillman samskillman Awaiting requested review from samskillman samskillman is a code owner

@nick-stroud nick-stroud Awaiting requested review from nick-stroud

At least 1 approving review is required to merge this pull request.

Assignees

@ACW101 ACW101

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ACW101 @nick-stroud @pawloch00