Test fixes for imageboot and Hyperdisk requirements #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jdieter. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
…ired We have a number of places where we check if a hyperdisk is required for a machine type, but each check is slightly different. In the last commit, a new function, `HyperdiskNeeded` was added to the hotattach test that has the most comprehensive check on whether or not a hyperdisk is required. This commit moves that function to utils/test_utils.go and updates all the other places where we need a hyperdisk to use that function, giving us one source of truth as to whether or not a hyperdisk is required for a machine type. Signed-off-by: Jonathan Dieter <jdieter@ciq.com>
In Rocky 8, when a reboot command is sent, the connection is often terminated before being properly disconnected, which is read as an error in this test. By checking whether the error message contains "signal: terminated" and only raising an error if it doesn't, we ensure that the test gets past this step. There is a second problem where a good number of the instance types don't reboot quickly enough to kill the test before the fatal error "marker file does not exist" is triggered. By adding a one minute sleep, we ensure that the fatal error is only triggered if the guest hasn't rebooted within 60 seconds. Signed-off-by: Jonathan Dieter <jdieter@ciq.com>
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 16, 2025
-- e5cf739 by Jonathan Dieter <jdieter@ciq.com>: Generalize HyperdiskNeeded function so it's used everywhere it's required We have a number of places where we check if a hyperdisk is required for a machine type, but each check is slightly different. In the last commit, a new function, `HyperdiskNeeded` was added to the hotattach test that has the most comprehensive check on whether or not a hyperdisk is required. This commit moves that function to utils/test_utils.go and updates all the other places where we need a hyperdisk to use that function, giving us one source of truth as to whether or not a hyperdisk is required for a machine type. Signed-off-by: Jonathan Dieter <jdieter@ciq.com> -- 75218f6 by Jonathan Dieter <jdieter@ciq.com>: Fix imageboot test to handle a couple of error conditions In Rocky 8, when a reboot command is sent, the connection is often terminated before being properly disconnected, which is read as an error in this test. By checking whether the error message contains "signal: terminated" and only raising an error if it doesn't, we ensure that the test gets past this step. There is a second problem where a good number of the instance types don't reboot quickly enough to kill the test before the fatal error "marker file does not exist" is triggered. By adding a one minute sleep, we ensure that the fatal error is only triggered if the guest hasn't rebooted within 60 seconds. Signed-off-by: Jonathan Dieter <jdieter@ciq.com> FUTURE_COPYBARA_INTEGRATE_REVIEW=#243 from jdieter:test-fixes 75218f6 PiperOrigin-RevId: 783927210
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 16, 2025
-- e5cf739 by Jonathan Dieter <jdieter@ciq.com>: Generalize HyperdiskNeeded function so it's used everywhere it's required We have a number of places where we check if a hyperdisk is required for a machine type, but each check is slightly different. In the last commit, a new function, `HyperdiskNeeded` was added to the hotattach test that has the most comprehensive check on whether or not a hyperdisk is required. This commit moves that function to utils/test_utils.go and updates all the other places where we need a hyperdisk to use that function, giving us one source of truth as to whether or not a hyperdisk is required for a machine type. Signed-off-by: Jonathan Dieter <jdieter@ciq.com> -- 75218f6 by Jonathan Dieter <jdieter@ciq.com>: Fix imageboot test to handle a couple of error conditions In Rocky 8, when a reboot command is sent, the connection is often terminated before being properly disconnected, which is read as an error in this test. By checking whether the error message contains "signal: terminated" and only raising an error if it doesn't, we ensure that the test gets past this step. There is a second problem where a good number of the instance types don't reboot quickly enough to kill the test before the fatal error "marker file does not exist" is triggered. By adding a one minute sleep, we ensure that the fatal error is only triggered if the guest hasn't rebooted within 60 seconds. Signed-off-by: Jonathan Dieter <jdieter@ciq.com> FUTURE_COPYBARA_INTEGRATE_REVIEW=#243 from jdieter:test-fixes 75218f6 PiperOrigin-RevId: 783927210
The `c3` family doesn't actually require a hyperdisk, but it doesn't support standard disks, so, given that there's no way to specify a minimum disk type in the test suite, let's just make the tests require a hyperdisk. Signed-off-by: Jonathan Dieter <jdieter@ciq.com>
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
-- e5cf739 by Jonathan Dieter <jdieter@ciq.com>: Generalize HyperdiskNeeded function so it's used everywhere it's required We have a number of places where we check if a hyperdisk is required for a machine type, but each check is slightly different. In the last commit, a new function, `HyperdiskNeeded` was added to the hotattach test that has the most comprehensive check on whether or not a hyperdisk is required. This commit moves that function to utils/test_utils.go and updates all the other places where we need a hyperdisk to use that function, giving us one source of truth as to whether or not a hyperdisk is required for a machine type. Signed-off-by: Jonathan Dieter <jdieter@ciq.com> -- 75218f6 by Jonathan Dieter <jdieter@ciq.com>: Fix imageboot test to handle a couple of error conditions In Rocky 8, when a reboot command is sent, the connection is often terminated before being properly disconnected, which is read as an error in this test. By checking whether the error message contains "signal: terminated" and only raising an error if it doesn't, we ensure that the test gets past this step. There is a second problem where a good number of the instance types don't reboot quickly enough to kill the test before the fatal error "marker file does not exist" is triggered. By adding a one minute sleep, we ensure that the fatal error is only triggered if the guest hasn't rebooted within 60 seconds. Signed-off-by: Jonathan Dieter <jdieter@ciq.com> FUTURE_COPYBARA_INTEGRATE_REVIEW=#243 from jdieter:test-fixes 75218f6 PiperOrigin-RevId: 783927210
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
PiperOrigin-RevId: 785480460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple of fixes for various tests. More detailed descriptions are in the commit messages.