这是indexloc提供的服务，不要输入任何密码
Skip to content

Refactor template to avoid using session file for type info #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2025
Merged

Refactor template to avoid using session file for type info #2529

merged 4 commits into from
Jul 21, 2025

Conversation

Deep1998
Copy link
Contributor

@Deep1998 Deep1998 commented Jul 9, 2025 •
edited
Loading

This PR refactors the reverse template to avoid using session file for anything other than table/column name-mappings. It instead relies of the Ddl and SourceDdl object for schema specific info. This refactoring is necessary to introduce the schemamapper and henceforth, overrides.

@Deep1998 Deep1998 changed the title Rev cp 2 Refactor template to avoid using session file for type info Jul 9, 2025
@Deep1998 Deep1998 force-pushed the rev-cp-2 branch 2 times, most recently from 49e10db to 78e6291 Compare July 9, 2025 11:30
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.14634% with 67 lines in your changes missing coverage. Please review.

Project coverage is 49.71%. Comparing base (c0fb979) to head (cb13298).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...cloud/teleport/v2/templates/SpannerToSourceDb.java 0.00% 35 Missing ⚠️
...rt/v2/templates/dbutils/dml/MySQLDMLGenerator.java 72.13% 9 Missing and 8 partials ⚠️
...2/templates/dbutils/dml/CassandraDMLGenerator.java 80.00% 4 Missing and 5 partials ⚠️
...eport/v2/templates/transforms/AssignShardIdFn.java 66.66% 3 Missing and 1 partial ⚠️
...v2/templates/dbutils/dml/CassandraTypeHandler.java 85.71% 0 Missing and 1 partial ⚠️
...v2/templates/transforms/SourceWriterTransform.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2529      +/-   ##
============================================
- Coverage     49.73%   49.71%   -0.03%     
- Complexity     4822     5179     +357     
============================================
  Files           948      948              
  Lines         57938    58038     +100     
  Branches       6259     6275      +16     
============================================
+ Hits          28818    28853      +35     
- Misses        27070    27123      +53     
- Partials       2050     2062      +12
Components Coverage Δ
spanner-templates 69.94% <59.14%> (-0.15%) ⬇️
spanner-import-export 68.61% <ø> (+0.13%) ⬆️
spanner-live-forward-migration 79.33% <ø> (+0.10%) ⬆️
spanner-live-reverse-replication 77.02% <59.14%> (-0.78%) ⬇️
spanner-bulk-migration 88.05% <ø> (+0.06%) ⬆️
Files with missing lines Coverage Δ
...plates/dbutils/processor/InputRecordProcessor.java 86.44% <100.00%> (-1.28%) ⬇️
...leport/v2/templates/transforms/SourceWriterFn.java 85.34% <100.00%> (+0.12%) ⬆️
...v2/templates/dbutils/dml/CassandraTypeHandler.java 84.73% <85.71%> (ø)
...v2/templates/transforms/SourceWriterTransform.java 0.00% <0.00%> (ø)
...eport/v2/templates/transforms/AssignShardIdFn.java 79.59% <66.66%> (+1.86%) ⬆️
...2/templates/dbutils/dml/CassandraDMLGenerator.java 84.96% <80.00%> (-5.10%) ⬇️
...rt/v2/templates/dbutils/dml/MySQLDMLGenerator.java 88.98% <72.13%> (-8.80%) ⬇️
...cloud/teleport/v2/templates/SpannerToSourceDb.java 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Deep1998 Deep1998 marked this pull request as ready for review July 9, 2025 17:51
@Deep1998 Deep1998 requested a review from a team as a code owner July 9, 2025 17:51
@Deep1998 Deep1998 marked this pull request as draft July 9, 2025 17:52
@Deep1998 Deep1998 force-pushed the rev-cp-2 branch 11 times, most recently from 7ce8030 to 6cd4f20 Compare July 15, 2025 06:39
@Deep1998 Deep1998 marked this pull request as ready for review July 16, 2025 16:34
bharadwaj-aditya
bharadwaj-aditya reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes are very spread out and hard to quantify or review because of the fan out. It would be cleaner to introduce an interface and swap between session file and alternates. It will keep the implementation and testing clean

rohitwali
rohitwali reviewed Jul 18, 2025
View reviewed changes
bharadwaj-aditya
bharadwaj-aditya approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as an intermediate PR before the interface changes are merged to simplify this code.

@Deep1998 Deep1998 merged commit ce12473 into GoogleCloudPlatform:main Jul 21, 2025
21 checks passed
@Deep1998 Deep1998 deleted the rev-cp-2 branch July 21, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitwali rohitwali rohitwali left review comments

@bharadwaj-aditya bharadwaj-aditya bharadwaj-aditya approved these changes

@manitgupta manitgupta Awaiting requested review from manitgupta manitgupta is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

@VardhanThigle VardhanThigle Awaiting requested review from VardhanThigle VardhanThigle is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

Assignees
No one assigned
Labels
improvement size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Deep1998 @rohitwali @bharadwaj-aditya